[#ZF-10069] setSubscription($data) always find $data in database - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.10.4
Fix Version/s: 1.10.7
Component/s: Zend_Feed_Pubsubhubbub
Labels:
None

Description

Under Zend/Feed/Pubsubhubbub/Model/Subscription.php one finds the function setSubscription($data) with code (line 54):

$result = $this->_db->find($data['id']);
if ($result) { ... }

At least in my application, where _db is a Mysqli interface, $result is always evaluated to true even if no rows are found.

Shouldn't the test be done instead with count()?

$result = $this->_db->find($data['id']);
if (count($result)>0) { ... }

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ramon Henrique Ornelas added a comment - 28/Jun/10 5:25 PM

This problem occur in all method of Zend_Feed_Pubsubhubbub_Model_Subscription.
Because Zend_Db_Table:>find() returns Zend_Db_Table_Rowset.

In This case the condition always is true. Sample code.

//same what not exists row to $id past, object returns Zend_Db_Table_Rowset
$result = $this->_db->find($key); 
if ($result) {  // always is true
    return true;
}

Show

Ramon Henrique Ornelas added a comment - 28/Jun/10 5:25 PM This problem occur in all method of Zend_Feed_Pubsubhubbub_Model_Subscription. Because Zend_Db_Table:>find() returns Zend_Db_Table_Rowset. In This case the condition always is true. Sample code.

//same what not exists row to $id past, object returns Zend_Db_Table_Rowset
$result = $this->_db->find($key); 
if ($result) {  // always is true
    return true;
}

Hide

Permalink

Ramon Henrique Ornelas added a comment - 30/Jun/10 12:16 PM

Fixed in trunk r22507.

Show

Ramon Henrique Ornelas added a comment - 30/Jun/10 12:16 PM Fixed in trunk r22507.

Hide

Permalink

Ramon Henrique Ornelas added a comment - 30/Jun/10 1:56 PM

Merged to branch release-1.10 r22509

Show

Ramon Henrique Ornelas added a comment - 30/Jun/10 1:56 PM Merged to branch release-1.10 r22509

People

Assignee:

Ramon Henrique Ornelas

Reporter:

Artur Adib

Vote (1)

Watch (2)

Dates

Created:

28/Jun/10 1:41 PM

Updated:

30/Jun/10 1:56 PM

Resolved:

30/Jun/10 1:56 PM