[#ZF-101] Zend_View_Abstract::_loadClass() doesn't work with classes on the include path (TRAC#99)

Zend Framework

Zend_View_Abstract::_loadClass() doesn't work with classes on the include path (TRAC#99)

Created: 21/Jun/06 09:47 PM Updated: 05/Jul/07 02:44 PM

Component/s:

Zend_View

Affects Version/s:

0.1.3

Fix Version/s:

0.6.0

Time Tracking:

Not Specified

File Attachments:

Zend_View_Abstract.patch (0.5 kb)

Tags:
Participants:	Elisamuel Resto, Jayson Minard, Matthew Weier O'Phinney, Nick Lo and Zend Framework

Description

« Hide

http://framework.zend.com/developer/ticket/99

Zend_View_Abstract::_loadClass() calls is_readable() to find out if the particular file exists on the path.

This causes problems when you want to have a set of common view helpers for multiple projects. In my case, I use a directory called Akrabat/View/Helper as part of a tree that mirrors the ZF tree for consistency.)

My preference would be to change

if (is_readable($dir . $file)) {

if (Zend::isReadable($dir . $file)) {

to solve this problem.

Suggested patch attached.

All

Comments

Work Log

Change History

FishEye

Crucible

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Zend Framework - 21/Jun/06 09:47 PM

05/28/06 16:18:19: Modified by rob.nospam@akrabat.com

attachment Zend_View_Abstract.patch added.

Suggested patch v1

[ Permlink | « Hide ]

Nick Lo - 26/Jun/06 12:55 AM

Rather than make the class dependant on Zend.php how about changing...

 
if (is_readable($dir . $file)) {
    include $dir . $file;

...to...

 
if (include $dir . $file) {

...which would achieve much the same result

[ Permlink | « Hide ]

Nick Lo - 26/Jun/06 11:19 PM

Forget my suggestion...

 
if (include $dir . $file) {

...as this produces warnings as each _path stack is looped over

[ Permlink | « Hide ]

Jayson Minard - 09/Jul/06 12:42 AM

Mind looking at this for 0.2.0?

[ Permlink | « Hide ]

Elisamuel Resto - 30/Jul/06 10:20 PM

One way is explode the path and then loop through it doing a Zend::isReadable() for each path with the requested file, that is somewhat slow in my eyes, but it's the only solution I see for making this work.

[ Permlink | « Hide ]

Matthew Weier O'Phinney - 02/Nov/06 12:11 AM

Fixed in 1428

[ Permlink | « Hide ]

Matthew Weier O'Phinney - 02/Nov/06 12:34 AM

Further analysis shows that the original behaviour was intentional. addScriptPath() can be used at any point to add additional view script paths to the view object. The reporter need only have done the following:

Unable to find source-code formatter for language: php. Available languages are: javascript, sql, xhtml, actionscript, none, html, xml, java

$view->addScriptPath('/path/to/common/view/scripts');

[ Permlink | « Hide ]

Matthew Weier O'Phinney - 02/Nov/06 12:35 AM

Behaviour was intentional, and a way to do as the reporter desired already existed in the code.