ZF-10260 - Issues - Zend Framework

ZF-10260: Zend_Paginator adapter's count()-method is called twice when using the paginationcontrol view helper

Issue Type:

Bug

Created:

2010-08-04T02:13:01.000+0000

Last Updated:

2011-01-25T09:23:53.000+0000

Status:

Open

Fix version(s):

Reporter:

Dieter Provoost (fabrizzio)

Assignee:

Ramon Henrique Ornelas (ramon)

Tags:

Zend_Paginator

Related issues:

ZF-8886

Attachments:

Description

When using the paginationcontrol view helper, the count()-method on the adapter get's called twice through the methods _calculatePageCount() and getTotalItemCount().

protected function _calculatePageCount()
{
    return (integer) ceil($this->getAdapter()->count() / $this->getItemCountPerPage());
}

and

public function getTotalItemCount()
{
    return count($this->getAdapter());
}

The return value of the adapter's count()-method should be held in a class member:

public function getTotalItemCount()
{
if($this->_totalItemCount === null)
        {
            $this->_totalItemCount = count($this->getAdapter());
        }
        return $this->_totalItemCount;
    }

Comments

Posted by Martin Meißner (meisii) on 2010-08-21T15:41:13.000+0000

I agree with that.

The affected functions look currently like this:


public function getTotalItemCount()
{
    return count($this->getAdapter());
}

protected function _calculatePageCount()
{
    return (integer) ceil($this->getAdapter()->count() / $this->getItemCountPerPage());
}

These could be changed as follows:


protected $_totalItemCount;

public function getTotalItemCount()
{
    if($this->_totalItemCount === null)
    {
        $this->_totalItemCount = count($this->getAdapter());
    }
    return $this->_totalItemCount;
}

protected function _calculatePageCount()
{
    $this->_totalItemCount = (integer) ceil($this->getAdapter()->count() / $this->getItemCountPerPage());
    return $this->_totalItemCount;
}

This works fine for me.