ZF-10448 - Issues - Zend Framework

ZF-10448: Cache Zend_Navigation not working

Issue Type:

Bug

Created:

2010-09-14T03:51:19.000+0000

Last Updated:

2012-06-01T08:24:43.000+0000

Status:

Open

Fix version(s):

Reporter:

Raphael Dehousse (thymus)

Assignee:

Frank Brückner (frosch)

Tags:

Zend_Navigation

Related issues:

ZF-8228

Attachments:

Description

Dears,

This issue is more or less the same as ZF-6746.

Since Zend_Navigation use spl_object_hash to generate an id for the page, if you cache a Zend_Navigation object, once the cache is loaded, the navigation is broken because spl_object_hash generation unique id for the instance of php. See also http://stackoverflow.com/questions/1370130/…

Possible fix (to test): don't use spl_object_id but md5(serialize(array(...))) representing the object. The active property must be saved as false and the parents property must be saved as null because the parents may changed once you add a page.

I will join the patch but should be improved and well tested.

Thank you for your hard work on the Zend Framework.

Best regards,

Raphaël Dehousse

Comments

Posted by Raphael Dehousse (thymus) on 2010-09-14T03:56:34.000+0000

Really strange, I cannot add a file (don't see any link to do that)

I paste the patch here then


Index: Page.php
===================================================================
--- Page.php    (revision 22938)
+++ Page.php    (working copy)
@@ -1065,7 +1065,29 @@
      */
     public final function hashCode()
     {
-        return spl_object_hash($this);
+        return md5(
+            serialize(
+                array_merge(
+                    $this->getCustomProperties(),
+                    array(
+                        'label'     => $this->getlabel(),
+                        'id'        => $this->getId(),
+                        'class'     => $this->getClass(),
+                        'title'     => $this->getTitle(),
+                        'target'    => $this->getTarget(),
+                        'rel'       => $this->getRel(),
+                        'rev'       => $this->getRev(),
+                        'order'     => $this->getOrder(),
+                        'resource'  => $this->getResource(),
+                        'privilege' => $this->getPrivilege(),
+                        'active'    => false,
+                        'visible'   => $this->isVisible(),
+                        'type'      => get_class($this),
+                        'pages'     => null,
+                    )
+                )
+            )
+        );
     }
 
     /**

Best regards,

Raphaël Dehousse

Posted by Kai Uwe (kaiuwe) on 2011-07-05T14:21:57.000+0000

Bad idea!


$hash = $page->hashCode();

if (array_key_exists($hash, $this->_index)) {
    // page is already in container
    return $this;
}

// adds page to container and sets dirty flag
$this->_pages[$hash] = $page;


public function testContainerWithTwoSamePages()
{
    $container = new Zend_Navigation(array(
        array(
            'label' => 'foo',
            'uri'   => 'foo',
            'bar'   => 'baz',
        ),
        array(
            'label' => 'foo',
            'uri'   => 'foo',
            'bar'   => 'baz',
        ),
    ));

    $found = array();
    foreach ($container as $page) {
        $found[] = $page->toArray();
    }

    $this->assertSame(2, count($found));
}

Fail!

Posted by Kai Uwe (kaiuwe) on 2011-07-05T16:20:20.000+0000

Maybe the www.php.net/manual/en/class.splobjectstorage.php" rel="nofollow">SplObjectStorage class is a possible variant. I will look into this (including the performance).

Posted by Raphael Dehousse (thymus) on 2011-07-12T15:09:59.000+0000

Hello,

The user would have to define a different id for the page then. Sth has to be different between the pages, otherwise, what could be the interest?

Thank you for looking for a solution ;)

Regards,

Raphaël Dehousse

Posted by Frank Brückner (frosch) on 2011-08-13T17:05:57.000+0000

{quote} Sth has to be different between the pages, otherwise, what could be the interest? {quote} It breaks the test from "Zend_Navigation_ContainerTest":


public function testAddPageShouldWorkWithPageInstance()
{
    $pageOptions = array(
        'label' => 'From array 1',
        'uri' => '#array'
    );

    $nav = new Zend_Navigation(array($pageOptions));

    $page = Zend_Navigation_Page::factory($pageOptions);
    $nav->addPage($page);

    $this->assertEquals(2, count($nav));
}

;)