ZF-10769: lost the facility in syslog

Issue Type:
Patch
Created:
2010-12-03T01:03:57.000+0000
Last Updated:
2011-03-26T11:51:11.000+0000
Status:
Resolved
Fix version(s):
  • 1.11.2 (30/Dec/10)
Reporter:
Siad Ardroumli (said)
Assignee:
Ramon Henrique Ornelas (ramon)
Tags:
  • Zend_Log
Related issues:
Attachments:

Description

If the constructor of Zend_Log_Writer_Syslog is called with $params array, the _facility property will set by setFacility method. The Problem is, that setFacility will return $this or return void in older versions, the facility property will be overwritten.

Index: library/Zend/Log/Writer/Syslog.php

--- library/Zend/Log/Writer/Syslog.php (revision 23466) +++ library/Zend/Log/Writer/Syslog.php (working copy) @@ -103,7 +103,7 @@

     $runInitializeSyslog = true;
     if (isset($params['facility'])) {

- $this->_facility = $this->setFacility($params['facility']); + $this->setFacility($params['facility']); $runInitializeSyslog = false; }

Comments

Posted by Siad Ardroumli (said) on 2010-12-03T01:05:12.000+0000

Index: library/Zend/Log/Writer/Syslog.php

--- library/Zend/Log/Writer/Syslog.php (revision 23466) +++ library/Zend/Log/Writer/Syslog.php (working copy) @@ -103,7 +103,7 @@

     $runInitializeSyslog = true;
     if (isset($params['facility'])) {

- $this->_facility = $this->setFacility($params['facility']); + $this->setFacility($params['facility']); $runInitializeSyslog = false; }

Posted by Ramon Henrique Ornelas (ramon) on 2010-12-05T08:03:51.000+0000

Fixed in trunk r23467 merged to release branch 1.11 r23468 - thanks.