ZF-10822: Invalid example in Zend_Filter_PregReplace documentation

Issue Type:
Docs: Problem
Created:
2010-12-14T09:35:14.000+0000
Last Updated:
2011-02-25T14:18:48.000+0000
Status:
Resolved
Fix version(s):
  • Next Major Release ()
Reporter:
Strict Coding (strictcoding)
Assignee:
Thomas Weidner (thomas)
Tags:
  • Zend_Filter
Related issues:
Attachments:

Description

In this page : http://framework.zend.com/manual/en/… the code sample below:

<?php $filter = new Zend_Filter_PregReplace(array('match' => 'bob', 'replace' => 'john')); $input = 'Hy bob!"; $filter->filter($input); // returns 'Hy john!' ?>

Contains 2 errors: - 'Hy bob!" begins with a single quote and ends with a double quote - 'match' => 'bob' triggers a "Delimiter must not be alphanumeric" error

Proposed fixed example:

<?php $filter = new Zend_Filter_PregReplace(array('match' => '/bob/', 'replace' => 'john')); $input = 'Hy bob!'; $filter->filter($input); // returns 'Hy john!' ?>

Comments

Posted by Udo Telaar (udo) on 2010-12-16T05:51:40.000+0000

patch attached

Posted by Udo Telaar (udo) on 2010-12-16T06:23:27.000+0000

Mixed up two patches in last patch file. This one is correct.

Posted by Udo Telaar (udo) on 2010-12-16T06:57:08.000+0000

[SVN:r23520:bittarman] ZF-10822: merging r23519 to release branch 1.11 (See: http://tinyurl.com/2bc7k25)

Posted by Udo Telaar (udo) on 2010-12-18T11:37:20.000+0000

Why is it reopened?

Posted by Strict Coding (strictcoding) on 2011-01-19T06:34:45.000+0000

There is still a problem on the second example, just below:

$filter = new Zend_Filter_PregReplace(); $filter->setMatchPattern(array('bob', 'Hy')) ->setReplacement(array('john', 'Bye')); $input = 'Hy bob!";

$filter->filter($input);

Should be:

$filter = new Zend_Filter_PregReplace(); $filter->setMatchPattern(array('/bob/', '/Hy/')) ->setReplacement(array('john', 'Bye'));

$input = 'Hy bob!';

$filter->filter($input);

Posted by Thomas Weidner (thomas) on 2011-02-25T14:16:13.000+0000

Fixed with GH-92