ZF-10843: Zend_View_Helper_HeadScript has a useless extra call to _isValid() in offsetSet()

Issue Type:
Bug
Created:
2010-12-17T14:57:52.000+0000
Last Updated:
2010-12-18T02:16:19.000+0000
Status:
Resolved
Fix version(s):
  • 1.11.2 (30/Dec/10)
Reporter:
Mike Dahlke (mjdahlke)
Assignee:
Adam Lundrigan (adamlundrigan)
Tags:
  • Zend_View
Related issues:
Attachments:

Description

On line 374 there is an extra call to _isValid(), it's result is not checked and is effectively useless.

Comments

Posted by Adam Lundrigan (adamlundrigan) on 2010-12-17T18:46:53.000+0000

Agreed. I've attached a patch against Zend_View_Helper_HeadScript which addresses the issue. All tests in Zend_View_Helper_HeadScriptTest still pass after modification.

Posted by Marc Hodgins (mjh_ca) on 2010-12-17T22:34:10.000+0000

Thank you for the report and patch. Fixed in r23548, applied to 1.11 release branch in r23549.

Posted by Ramon Henrique Ornelas (ramon) on 2010-12-18T02:16:19.000+0000

Reassigned