ZF-10843: Zend_View_Helper_HeadScript has a useless extra call to _isValid() in offsetSet()


On line 374 there is an extra call to _isValid(), it's result is not checked and is effectively useless.


Agreed. I've attached a patch against Zend_View_Helper_HeadScript which addresses the issue. All tests in Zend_View_Helper_HeadScriptTest still pass after modification.

Thank you for the report and patch. Fixed in r23548, applied to 1.11 release branch in r23549.