ZF-11106: Harcoded white space with value of '1' instead of 'barThinWidth'

Issue Type:
Bug
Created:
2011-02-22T11:27:05.000+0000
Last Updated:
2012-11-21T08:09:30.000+0000
Status:
Resolved
Fix version(s):
  • 1.11.4 (03/Mar/11)
Reporter:
Mickael Perraud (mikaelkael)
Assignee:
Mickael Perraud (mikaelkael)
Tags:
  • Zend_Barcode
Related issues:
Attachments:

Description

In Code25 and Code39, whitespaces between characters are hardcoded with value of '1' instead of 'barThinWidth'. If you do this:


$barcode->setBarThinWidth(2);
$barcode->setBarThickWidth(6);

This leads to smaller barcode but not smaller image => textual characters are not centered

Comments

Posted by Mickael Perraud (mikaelkael) on 2011-02-22T12:52:02.000+0000

Fixed with r23755, merged to 1.11 branch with r23756

Posted by Stefan Koopmanschap (stefan) on 2011-02-23T01:48:03.000+0000

I am still running into trouble with the Code128 barcode that I'm using throughout my application. I am also using Leitcode and Identcode and these seem not to be affected at the moment, it seems to just be Code128 for me at the moment.

Posted by Stefan Koopmanschap (stefan) on 2011-02-23T01:50:00.000+0000

I applied the http://framework.zend.com/code/revision.php/… patch to my local ZF installation and generated some barcodes. This is still the result.

Posted by Mickael Perraud (mikaelkael) on 2011-02-23T02:48:49.000+0000

Argh! :(

I omit line 232 in Code128.php:


                $barcodeTable[] = array($c, 1, 0, 1);

should be:


                $barcodeTable[] = array($c, $this->_barThinWidth, 0, 1);

I will patch it this evening

Posted by Mickael Perraud (mikaelkael) on 2011-02-23T12:30:48.000+0000

New patch with r23760 and merged in 1.11 branch with r23761

Posted by Stefan Koopmanschap (stefan) on 2011-02-24T01:25:13.000+0000

I can confirm that the implemented fix indeed solves the problem.

Posted by nike shox (nike shox) on 2012-11-21T08:09:30.000+0000

words http://www.nikeshoxsko.biz Brandon RichardThis last Torsdag, foret Florida-baserte sneakerheads opp http://www.nikeshoxsko.biz i hopetall utenfor Niketown Miami for en attract armbånd for fredagens limited utgivelse of the etterlengtede "Miami Nights" Nike LeBron http://www.nikeshoxsko.biz Low.