ZF-11157: Two instructions in one line in Zend_Search_Lucene_Storage_Directory_Filesystem

Issue Type:
Coding Standards Violation
Created:
2011-03-10T06:55:02.000+0000
Last Updated:
2011-05-03T14:22:39.000+0000
Status:
Resolved
Fix version(s):
  • 1.11.6 (05/May/11)
Reporter:
Pawel Chyl (chyl)
Assignee:
Adam Lundrigan (adamlundrigan)
Tags:
  • Zend_Search_Lucene
  • lucene
Related issues:
Attachments:

Description

Class: {{Zend_Search_Lucene_Storage_Directory_Filesystem}}

Method: {{deleteFile}}

Line: 209

Contents: {{$trackErrors = ini_get('track_errors'); ini_set('track_errors', '1');}}

Should be {{$trackErrors = ini_get('track_errors');}} {{ini_set('track_errors', '1');}}

Comments

Posted by Adam Lundrigan (adamlundrigan) on 2011-04-30T16:33:24.000+0000

As far as I can see, there is nothing in the ZF Coding Standards document that disallows this sort of construct. In my opinion it does make code harder to read, so I am inclined to agree that it should be changed.

Fixed in trunk r23906

Posted by Adam Lundrigan (adamlundrigan) on 2011-05-03T14:22:00.000+0000

Merged to release branch 1.11 r23964