ZF-11171: Zend_Translate_Adapter_Gettext fopens and doesn't fclose
Description
In _loadTranslationData, Zend_Translate_Adapter_Gettext fopens the translation file and never fcloses it.
This can result in PHP holding a lot of open file handles for files that, as far as I can tell, have already been fully processed. Handles for any invalid files encountered during a scan are also held.
In particular, it seems like there should be fclose calls before both "is not a gettext file" exception throws and before the function returns.
Comments
Posted by Adam Lundrigan (adamlundrigan) on 2011-04-30T06:49:32.000+0000
Fixed in trunk r23903
Posted by Satoru Yoshida (satoruyoshida) on 2011-05-03T11:20:46.000+0000
Hello, Adam. I will push [solve] button as proxy for You. If You want to release at next mini, You can merge this commit fron trunk to 1.11 branch.
Thanks.
Posted by Thomas Weidner (thomas) on 2011-05-03T14:22:58.000+0000
Adam, thnx for your fix
Still reopening this issue
Please do actually not close I18n related issues as I18n is being reworked. This is intentionally
Thnx
Posted by Satoru Yoshida (satoruyoshida) on 2011-05-03T15:05:07.000+0000
You can find in 1.11 branch at r23961
Posted by Ralph Schindler (ralph) on 2011-05-03T17:01:04.000+0000
Thomas, unless the commit doesn't look good, and you have valid issues with the work done, please don't reassign and reopen. Adam did acceptable work, it was reviewed and approved.
Posted by Thomas Weidner (thomas) on 2011-08-30T19:22:30.000+0000
@Ralph: As there was no response to my request regarding I18n components I integrated it within ZF2 with GH-277. If this is against your intention on how I have to handle issues for my components please state it and I will remove it again from ZF2.