Issues

ZF-11171: Zend_Translate_Adapter_Gettext fopens and doesn't fclose

Description

In _loadTranslationData, Zend_Translate_Adapter_Gettext fopens the translation file and never fcloses it.

This can result in PHP holding a lot of open file handles for files that, as far as I can tell, have already been fully processed. Handles for any invalid files encountered during a scan are also held.

In particular, it seems like there should be fclose calls before both "is not a gettext file" exception throws and before the function returns.

Comments

Fixed in trunk r23903

Hello, Adam. I will push [solve] button as proxy for You. If You want to release at next mini, You can merge this commit fron trunk to 1.11 branch.

Thanks.

Adam, thnx for your fix

Still reopening this issue

Please do actually not close I18n related issues as I18n is being reworked. This is intentionally

Thnx

You can find in 1.11 branch at r23961

Thomas, unless the commit doesn't look good, and you have valid issues with the work done, please don't reassign and reopen. Adam did acceptable work, it was reviewed and approved.

@Ralph: As there was no response to my request regarding I18n components I integrated it within ZF2 with GH-277. If this is against your intention on how I have to handle issues for my components please state it and I will remove it again from ZF2.