ZF-11514: Zend_Mail_Message incorrectly merges configuration flags supplied via constructor

Issue Type:
Bug
Created:
2011-06-29T15:09:21.000+0000
Last Updated:
2011-06-29T15:24:14.000+0000
Status:
Resolved
Fix version(s):
  • 1.11.8 (07/Jul/11)
Reporter:
Adam Lundrigan (adamlundrigan)
Assignee:
Adam Lundrigan (adamlundrigan)
Tags:
  • Zend_Mail
Related issues:
Attachments:

Description

{{Zend_Mail_Message}}, Line 76:


$this->_flags = array_combine($params['flags'], $params['flags']);

This just combines the supplied array with itself then assigns to class member. Should be:


$this->_flags = array_merge($this->_flags, array_combine($params['flags'], $params['flags']));

To merge it into the member without overwriting the pre-existing defaults.

I've marked this as trivial since {{Zend_Mail_Message}} doesn't currently define any default values, so overwriting the class member doesn't have any negative effect.

Comments

Posted by Adam Lundrigan (adamlundrigan) on 2011-06-29T15:24:14.000+0000

Fixed in trunk r24162 Merged to release-1.11 in r24163