ZF-11598: Improvement Zend_Http_Client::getAdapter()

Issue Type:
Improvement
Created:
2011-07-23T14:04:20.000+0000
Last Updated:
2011-07-30T02:43:59.000+0000
Status:
Closed
Fix version(s):
  • 1.11.10 (04/Aug/11)
Reporter:
Ramon Henrique Ornelas (ramon)
Assignee:
Enrico Zimuel (zimuel)
Tags:
  • Zend_Http_Client
Related issues:
Attachments:

Description

Case the 'adapter' was assigned in config the method Zend_Http_Client::getAdapter() should verify if the o adapter is null and assign in next. Sample code below.


public function getAdapter()
{
   if (null === $this->adapter) {
       $this->setAdapter($this->config['adapter']);
   }

    return $this->adapter;
}

Comments

Posted by Ramon Henrique Ornelas (ramon) on 2011-07-23T14:49:11.000+0000

Should allow: $client = new Zend_Http_Client(null, array('adapter' => 'Zend_Http_Client_Adapter_Test')); $client->getAdapter();

Posted by Ramon Henrique Ornelas (ramon) on 2011-07-23T15:26:28.000+0000

Commit in trunk r24261.

Posted by Enrico Zimuel (zimuel) on 2011-07-29T15:53:34.000+0000

Added the test case (commit in trunk 24298)

Posted by Enrico Zimuel (zimuel) on 2011-07-29T19:05:41.000+0000

Solved in branches/release-1.11 (commit 24302)

Posted by Ramon Henrique Ornelas (ramon) on 2011-07-30T02:32:11.000+0000

@Enrico I already had added a test case in StaticTest ;), No problem will deleted.

Greetings Ramon

Posted by Ramon Henrique Ornelas (ramon) on 2011-07-30T02:43:59.000+0000

Deleted test case in r24308.