ZF-1167: consistency: addRole() adds a role, but there is not addResource()

Issue Type:
Improvement
Created:
2007-03-29T15:56:54.000+0000
Last Updated:
2009-08-16T18:42:45.000+0000
Status:
Resolved
Fix version(s):
  • 1.9.1 (11/Aug/09)
Reporter:
Gavin (gavin)
Assignee:
Ralph Schindler (ralph)
Tags:
  • Zend_Acl
Related issues:
Attachments:

Description

To me, the presence of the method addRole(), and the lack of a corresponding method addResource() looks like an inconsistency. Given our past diligence to resolve inconsistencies, this issue can record a decision regarding this for future reference.

Comments

Posted by Marc Jakubowski (octavian) on 2007-12-17T10:22:33.000+0000

That´s what the add() method is there for, isn´t it? Is this issue only about the name or am I missing someting obvious?

Posted by Wil Sinclair (wil) on 2008-03-21T17:05:34.000+0000

This issue should have been fixed for the 1.5 release.

Posted by Wil Sinclair (wil) on 2008-04-18T13:12:01.000+0000

This doesn't appear to have been fixed in 1.5.0. Please update if this is not correct.

Posted by Wil Sinclair (wil) on 2008-06-09T13:16:04.000+0000

Let's decide if we think this is worth doing and fix or close down the issue as necessary.

Posted by Wil Sinclair (wil) on 2009-01-14T13:31:40.000+0000

Assigning to Ralph to get closure on this issues.

Posted by Sebastian Krebs (kingcrunch) on 2009-08-13T12:40:15.000+0000

Method found in current rev 17577 of 1.9 branch, thanks for that. But now there is the inconsistency, that the other resource related methods has not their "Resource" suffix

  • has() --> hasResource()
  • remove() --> removeResource()
  • removeAll() --> removeResourceAll()
  • get() --> getResource()

I would also prefer to rename the "removeAll()" methods to "clear()" as ... they sounds strange ^^ - removeRoleAll() -> clearRoles() - removeResourceAll() -> clearResources() Just a suggestion