ZF-2019: Zend_Http_Client->setHeaders() is too strict...

Issue Type:
Bug
Created:
2007-10-01T09:08:33.000+0000
Last Updated:
2009-07-24T04:25:46.000+0000
Status:
Resolved
Fix version(s):
  • 1.5.0 (17/Mar/08)
Reporter:
Eric Coleman (eric)
Assignee:
Shahar Evron (shahar)
Tags:
  • Zend_Http_Client
Related issues:
Attachments:

Description

setHeaders() checks the header name to make sure it's valid. Some vendors, such as SWSoft provide a API that requires several non-standard HTTP headers. I attached a patch to make it strict/not strict

Comments

Posted by Kevin McArthur (kevin) on 2007-10-10T15:15:09.000+0000

I'd suggest that instead of adding strict mode settings that instead the job of adding http compliant headers be left up to the programmer. At the least, we shouldn't purposefully make sw-softs api incompatible, and at the best, the regexp just isnt needed and is only extra processing and weight.

I'd change the patch to remove the check.

Posted by Thomas Weidner (thomas) on 2007-10-15T14:01:35.000+0000

Assigned to Shahar

Posted by Shahar Evron (shahar) on 2007-10-16T12:07:28.000+0000

Should now be fixed in r. 6648. You can disable header name checking by passing the 'strict' => 'false' configuration option to the client.