[#ZF-202] The newly supported pdo_mysql style naming syntax no longer works, when specifying a PDO adapter name for Zend_Db

Zend Framework

The newly supported pdo_mysql style naming syntax no longer works, when specifying a PDO adapter name for Zend_Db

Created: 06/Jul/06 06:42 PM Updated: 05/Jul/07 02:44 PM

Component/s:

Zend_Db

Affects Version/s:

0.1.5

Fix Version/s:

0.1.5

Time Tracking:

Not Specified

External References:

Re: [fw-general] E_WARNING (Confluence: Zend Framework List Archive: FW-GENERAL)

Returnpath: <fwgeneralreturn4264zf.general=runbox.com@lists.zend.com> Received: (qmail 29600 invoked by uid 100); 7 Jul 2006 12:21:50 0000 MessageID: <32067163.1152291006765.JavaMail.root@framework.zend.com> Date: Fri, 7 Jul 2006 14:21:43 0200 From: "...

Resolution Date:

07/Jul/06 08:48 PM

Description

« Hide

The support for the underscore naming syntax of Zend_Db Adapters (i.e. pdo_mysel) was broken in changeset 829.

Also, Andi requested an E_WARNING when adapter names are specified without the underscore naming syntax.
After changeset 829, the warning is no longer the requested type.

All

Comments

Work Log

Change History

FishEye

Crucible

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Gavin - 06/Jul/06 07:30 PM

http://framework.zend.com/fisheye/changelog/Zend_Framework/?cs=792

http://framework.zend.com/fisheye/changelog/Zend_Framework/?cs=808

http://framework.zend.com/fisheye/changelog/Zend_Framework/?cs=824

http://framework.zend.com/fisheye/changelog/Zend_Framework/?cs=829

http://framework.zend.com/fisheye/changelog/Zend_Framework?cs=831

http://framework.zend.com/fisheye/changelog/Zend_Framework/?cs=832

I fixed 3 times, but the last changeset broke it again, so I can not close this issue.

[ Permlink | « Hide ]

Mislav Marohni? - 07/Jul/06 05:13 AM

I've looked at the changesets and I don't understand why so much trouble and changesets about so trivial an issue. Also, can you describe what exactly is broken?

Also, it's E_USER_WARNING, not E_WARNING. We can't use non-user error types

[ Permlink | « Hide ]

Mislav Marohni? - 07/Jul/06 06:15 AM

E_USER_WARNING is in latest rev: CS 839

Can we resolve this now? This isn't really a 0.1.5 issue because the code is simply going to be removed by then

[ Permlink | « Hide ]

Mike Naberezny - 07/Jul/06 12:14 PM

Fixed in changeset 839

[ Permlink | « Hide ]

Gavin - 07/Jul/06 03:49 PM

Still broken.

See the original changeset for an example of working code:
http://framework.zend.com/fisheye/browse/Zend_Framework/trunk/library/Zend/Db.php?r1=430&r2=792

[ Permlink | « Hide ]

Jayson Minard - 07/Jul/06 06:42 PM

Assigning back to Gavin to finish for 0.1.5 release

[ Permlink | « Hide ]

Gavin - 07/Jul/06 08:48 PM

Fixed again. See FishEye link for more information.

[ Permlink | « Hide ]

Jayson Minard - 11/Jul/06 11:54 AM

0.1.5 released

[ Permlink | « Hide ]

Gavin - 11/Jul/06 01:32 PM

Note: There were numerous commits repeatedly fixing and breaking support for the naming required in ZF 0.1.4 and prior - e.g. 'pdomysql'. Release 0.1.5 will support both 'PDO_MYSQL' and 'pdomysql'. Release 0.2 will not support 'pdomysql'.

Specifying PDO adapter names without underscores is now deprecated, and will result in an error of level E_USER_WARNING, if underscores are not used. Both the check for underscores and the warning will be removed in release 0.2, after everyone has had time to update their code by adding underscores to their PDO adapter names. By convention, preference is given to using all capitals when naming PDO adapters (e.g. PDO_MYSQL).

[ Permlink | « Hide ]

Gavin - 11/Jul/06 04:24 PM

http://framework.zend.com/wiki/display/ZFMLGEN/mail/1539 - strict comparisons (===) are faster and preferred when semantically more accurate than non-strict comparisons

Directly accessing characters within strings will continue to be supported by PHP:
http://www.zend.com/manual/language.types.string.php
http://www.php.net/heredoc