Zend Framework

More efficient differentiation between structs and arrays

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.5.0RC1
  • Fix Version/s: 1.5.1
  • Component/s: Zend_XmlRpc_Client
  • Labels:
    None
  • Fix Version Priority:
    Must Have

Description

Instead of iterating over each key, array_keys() in combination with range() is much faster to determine wheither it is an array or a struct.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Scheduling for 1.0.3

Show
Matthew Weier O'Phinney added a comment - Scheduling for 1.0.3
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Updated and pushed to release branch as of r6938.

Show
Matthew Weier O'Phinney added a comment - Updated and pushed to release branch as of r6938.
Hide
Permalink
Lars Strojny added a comment -

I'm sorry, but you change made it even worse. I attached a benchmark between our two strategies to differentiate.

Show
Lars Strojny added a comment - I'm sorry, but you change made it even worse. I attached a benchmark between our two strategies to differentiate.
Hide
Permalink
Lars Strojny added a comment -

Here is my result:
array_reduce(): 1.23774003983
count()/range(): 0.39503288269

Show
Lars Strojny added a comment - Here is my result: array_reduce(): 1.23774003983 count()/range(): 0.39503288269
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Scheduling for 1.5.0RC2

Show
Matthew Weier O'Phinney added a comment - Scheduling for 1.5.0RC2
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Applied in trunk and 1.5 release branch

Show
Matthew Weier O'Phinney added a comment - Applied in trunk and 1.5 release branch
Hide
Permalink
Matthew Weier O'Phinney added a comment -

This patch highlights a huge issue with array/struct detection.

With the patch applied, we now have a situation where passing an empty array to a field expecting an array now results in an invalid argument exception – because the empty array is incorrectly detected as a struct.

Before the patch was applied, we had the opposite siutation: passing an empty array to a field expecting a struct resulted in an invalid argument exception, because the empty array was detected as an array.

I'm re-opening the ticket, as we need to do some detection in the client for empty arrays and cast them to the appropriate types.

Show
Matthew Weier O'Phinney added a comment - This patch highlights a huge issue with array/struct detection. With the patch applied, we now have a situation where passing an empty array to a field expecting an array now results in an invalid argument exception – because the empty array is incorrectly detected as a struct. Before the patch was applied, we had the opposite siutation: passing an empty array to a field expecting a struct resulted in an invalid argument exception, because the empty array was detected as an array. I'm re-opening the ticket, as we need to do some detection in the client for empty arrays and cast them to the appropriate types.
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Fix committed in trunk in r8953 and in release-1.5 branch in r 8954. This should resolve all issues at this point.

Show
Matthew Weier O'Phinney added a comment - Fix committed in trunk in r8953 and in release-1.5 branch in r 8954. This should resolve all issues at this point.

People

Vote (0)
Watch (0)

Dates

  • Due:
    Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2h
Original Estimate - 2 hours
Remaining:
2h
Remaining Estimate - 2 hours
Logged:
Not Specified
Time Spent - Not Specified
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.