Matthew Weier O'Phinney - 16/Nov/07 03:05 PM Scheduling for 1.0.3

Matthew Weier O'Phinney - 26/Nov/07 10:18 AM Updated and pushed to release branch as of r6938.

Lars Strojny - 03/Dec/07 06:43 PM I'm sorry, but you change made it even worse. I attached a benchmark between our two strategies to differentiate.

Lars Strojny - 03/Dec/07 06:44 PM Here is my result: array_reduce(): 1.23774003983 count()/range(): 0.39503288269

Matthew Weier O'Phinney - 06/Mar/08 10:14 AM Scheduling for 1.5.0RC2

Matthew Weier O'Phinney - 06/Mar/08 08:00 PM Applied in trunk and 1.5 release branch

Matthew Weier O'Phinney - 17/Mar/08 01:17 PM This patch highlights a huge issue with array/struct detection. With the patch applied, we now have a situation where passing an empty array to a field expecting an array now results in an invalid argument exception – because the empty array is incorrectly detected as a struct. Before the patch was applied, we had the opposite siutation: passing an empty array to a field expecting a struct resulted in an invalid argument exception, because the empty array was detected as an array. I'm re-opening the ticket, as we need to do some detection in the client for empty arrays and cast them to the appropriate types.

Matthew Weier O'Phinney - 21/Mar/08 11:24 AM Fix committed in trunk in r8953 and in release-1.5 branch in r 8954. This should resolve all issues at this point.