Zend Framework

Zend_Filter::get() could be better named

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.0.2
  • Fix Version/s: 1.9.0
  • Component/s: Zend_Filter
  • Labels:
    None
  • Fix Version Priority:
    Nice to Have

Description

Zend_Filter::get() may be better named staticFilter() or something similar, the goal being to indicate what the method does.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wil Sinclair added a comment -

This issue should have been fixed for the 1.5 release.

Show
Wil Sinclair added a comment - This issue should have been fixed for the 1.5 release.
Hide
Permalink
Wil Sinclair added a comment -

This doesn't appear to have been fixed in 1.5.0. Please update if this is not correct.

Show
Wil Sinclair added a comment - This doesn't appear to have been fixed in 1.5.0. Please update if this is not correct.
Hide
Permalink
Wil Sinclair added a comment -

Please evaluate and categorize/assign as necessary.

Show
Wil Sinclair added a comment - Please evaluate and categorize/assign as necessary.
Hide
Permalink
Andries Seutens added a comment -

+1 for getStaticFilter()

In the MVC layer Matthew has used this naming for the helperBroker too HelperBroker::getStaticHelper('x')

Show
Andries Seutens added a comment - +1 for getStaticFilter() In the MVC layer Matthew has used this naming for the helperBroker too HelperBroker::getStaticHelper('x')
Hide
Permalink
Wil Sinclair added a comment -

Matthew, please decide what we should do with this. 3 possibilities that I see: close as 'will not fix', mark as 'postponed' and fix version 'next major release', or handle it now by deprecating the get() method and adding the new method. The last possibility has the advantage that users could start migrating their apps now, although we may need to firm up our deprecation policies and processes before taking such actions.

Show
Wil Sinclair added a comment - Matthew, please decide what we should do with this. 3 possibilities that I see: close as 'will not fix', mark as 'postponed' and fix version 'next major release', or handle it now by deprecating the get() method and adding the new method. The last possibility has the advantage that users could start migrating their apps now, although we may need to firm up our deprecation policies and processes before taking such actions.
Hide
Permalink
Thomas Weidner added a comment -

Under code review since 26.06.2009

Show
Thomas Weidner added a comment - Under code review since 26.06.2009
Hide
Permalink
Thomas Weidner added a comment -

Implemented with r17073.

After discussion with the dev-team we changed the function name to Zend_Filter::filterStatic()

Show
Thomas Weidner added a comment - Implemented with r17073. After discussion with the dev-team we changed the function name to Zend_Filter::filterStatic()

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
1d
Original Estimate - 1 day
Remaining:
1d
Remaining Estimate - 1 day
Logged:
Not Specified
Time Spent - Not Specified
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.