[#ZF-221] Zend_Filter::isDigits() operates erratically - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 0.1.3, 0.1.4, 0.1.5
Fix Version/s: 0.2.0
Component/s: Zend_Filter
Labels:
None

Description

Zend_Filter::isDigits() sometimes returns false on values that are digits. The solution is simple:

public static function isDigits($value)
{
---    return ctype_digit($value);
+++    return ctype_digit((string) $value);
}

I marked this major because I use this for all ID validation in my applications.

Issue Links

This issue is related to:
ZF-11610	ctype_digit in Zend Framework

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Mark Evans added a comment - 12/Jul/06 5:00 AM

Can you give some examples where it fails?

Show

Mark Evans added a comment - 12/Jul/06 5:00 AM Can you give some examples where it fails?

Hide

Permalink

Matthew Ratzloff added a comment - 12/Jul/06 10:17 AM

Fatal error: Uncaught exception 'Exception' with message 'Expected second ID' in /path/to/ExampleController.php:312
Stack trace:
#0 /path/to/ExampleController.php(184): ExampleController->doSomething('7', 19)[...]

public function doSomething($firstId, $secondId)
{
    if(!Zend_Filter::isDigits($firstId))
    {
        throw new Exception("Expected first ID");
    }

    if(!Zend_Filter::isDigits($secondId))
    {
        throw new Exception("Expected second ID");
    }
}

Changing Zend_Filter::isDigits() as indicated results in correct execution. See http://us2.php.net/manual/en/function.ctype-digit.php.

You might also change to

return preg_match("/^\d+$/", $value);

which is what I went ahead and did.

Show

Matthew Ratzloff added a comment - 12/Jul/06 10:17 AM

Fatal error: Uncaught exception 'Exception' with message 'Expected second ID' in /path/to/ExampleController.php:312 Stack trace: #0 /path/to/ExampleController.php(184): ExampleController->doSomething('7', 19)[...]

public function doSomething($firstId, $secondId)
{
    if(!Zend_Filter::isDigits($firstId))
    {
        throw new Exception("Expected first ID");
    }

    if(!Zend_Filter::isDigits($secondId))
    {
        throw new Exception("Expected second ID");
    }
}

Changing Zend_Filter::isDigits() as indicated results in correct execution. See http://us2.php.net/manual/en/function.ctype-digit.php. You might also change to

return preg_match("/^\d+$/", $value);

which is what I went ahead and did.

Hide

Permalink

Matthew Ratzloff added a comment - 12/Jul/06 10:22 AM

I meant to say see the last two comments of http://us2.php.net/manual/en/function.ctype-digit.php

So much for dynamic typing. A bug in PHP?

Show

Matthew Ratzloff added a comment - 12/Jul/06 10:22 AM I meant to say see the last two comments of http://us2.php.net/manual/en/function.ctype-digit.php So much for dynamic typing.

A bug in PHP?

People

Assignee:

Mark Evans

Reporter:

Matthew Ratzloff

Vote (0)

Watch (0)

Dates

Created:

10/Jul/06 3:53 PM

Updated:

26/Jul/11 11:36 AM

Resolved:

13/Jul/06 9:27 PM