[#ZF-2293] Zend_Db_Adapter_Pdo_Sqlite::describeTable() bugs - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Critical
Resolution: Fixed
Affects Version/s: 1.0.3
Fix Version/s: 1.0.4
Component/s: Zend_Db
Labels:
None

Fix Version Priority:
Must Have

Description

if you've a varchar(50) field in a table, describeTable() method will return that the field type is "varchar(50)" instead of "varchar" width length = 50

in the code i can see some "@todo" comments but this task is very simple to complete because you can simply copy the code of the mysql adapter

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

sqlite.diff

30/Jan/08 2:40 AM

0.8 kB

Fabrizio Balliano

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Fabrizio Balliano added a comment - 28/Dec/07 2:53 AM

what about this issue?

Show

Fabrizio Balliano added a comment - 28/Dec/07 2:53 AM what about this issue?

Hide

Permalink

Darby Felton added a comment - 10/Jan/08 10:24 AM

Care to contribute a patch?

Show

Darby Felton added a comment - 10/Jan/08 10:24 AM Care to contribute a patch?

Hide

Permalink

Fabrizio Balliano added a comment - 10/Jan/08 10:34 AM

if you lool at the same function for pdo_mysql you'll find that with a 5 min cut/paste this bug will be fixed

Show

Fabrizio Balliano added a comment - 10/Jan/08 10:34 AM if you lool at the same function for pdo_mysql you'll find that with a 5 min cut/paste this bug will be fixed

Hide

Permalink

Darby Felton added a comment - 29/Jan/08 2:22 PM

Resolved for 1.5.0 RC1 with SVN r7686.

Show

Darby Felton added a comment - 29/Jan/08 2:22 PM Resolved for 1.5.0 RC1 with SVN r7686.

Hide

Permalink

Darby Felton added a comment - 29/Jan/08 2:25 PM

Resolved for 1.0.4 with SVN r7687.

Show

Darby Felton added a comment - 29/Jan/08 2:25 PM Resolved for 1.0.4 with SVN r7687.

Hide

Permalink

Fabrizio Balliano added a comment - 30/Jan/08 2:19 AM

hi and thank for the fix but this is only partial, cause it doesn't care about

'SCALE' => null, // @todo
'PRECISION' => null, // @todo
'UNSIGNED' => null, // @todo

Show

Fabrizio Balliano added a comment - 30/Jan/08 2:19 AM hi and thank for the fix but this is only partial, cause it doesn't care about 'SCALE' => null, // @todo 'PRECISION' => null, // @todo 'UNSIGNED' => null, // @todo

Hide

Permalink

Fabrizio Balliano added a comment - 30/Jan/08 2:23 AM

ok reading the sqlite3 documentation it seems that it doesn't have unsigned data thus the "unsigned" index of the describetable could remain NULL

Show

Fabrizio Balliano added a comment - 30/Jan/08 2:23 AM ok reading the sqlite3 documentation it seems that it doesn't have unsigned data thus the "unsigned" index of the describetable could remain NULL

Hide

Permalink

Fabrizio Balliano added a comment - 30/Jan/08 2:38 AM

i created a patch to solve the problems above, it's been created agains r7686
do you think it could be added soon?

225,227c225
< list($length, $scale, $precision, $unsigned, $primary, $primaryPosition, $identity)
< = array(null, null, null, null, false, null, false);
<
—
> list($length, $primary, $primaryPosition, $identity) = array(null, false, null, false);
231,234d228
< } else if (preg_match('/^decimal((\d+),(\d+))/i', $row[$type], $matches)) {
< $row[$type] = 'DECIMAL';
< $precision = $matches[1];
< $scale = $matches[2];
254,256c248,250
< 'SCALE' => $scale,
< 'PRECISION' => $precision,
< 'UNSIGNED' => $unsigned,
—
> 'SCALE' => null, // @todo
> 'PRECISION' => null, // @todo
> 'UNSIGNED' => null, // @todo

Show

Fabrizio Balliano added a comment - 30/Jan/08 2:38 AM i created a patch to solve the problems above, it's been created agains r7686 do you think it could be added soon? 225,227c225 < list($length, $scale, $precision, $unsigned, $primary, $primaryPosition, $identity) < = array(null, null, null, null, false, null, false); < — > list($length, $primary, $primaryPosition, $identity) = array(null, false, null, false); 231,234d228 < } else if (preg_match('/^decimal((\d+),(\d+))/i', $row[$type], $matches)) { < $row[$type] = 'DECIMAL'; < $precision = $matches[1]; < $scale = $matches[2]; 254,256c248,250 < 'SCALE' => $scale, < 'PRECISION' => $precision, < 'UNSIGNED' => $unsigned, — > 'SCALE' => null, // @todo > 'PRECISION' => null, // @todo > 'UNSIGNED' => null, // @todo

Hide

Permalink

Fabrizio Balliano added a comment - 30/Jan/08 2:40 AM

attaching the patch as a file:
diff Sqlite.php Sqlite.php.old

Show

Fabrizio Balliano added a comment - 30/Jan/08 2:40 AM attaching the patch as a file: diff Sqlite.php Sqlite.php.old

Hide

Permalink

Darby Felton added a comment - 30/Jan/08 7:34 AM

Reopening issue

Show

Darby Felton added a comment - 30/Jan/08 7:34 AM Reopening issue

Hide

Permalink

Darby Felton added a comment - 31/Jan/08 8:49 AM

Unfortunately, I cannot use your patch until you have signed a Contributor License Agreement, but I think I can figure it out independently. Once you've signed the CLA, you can work on just about anything you like! Please consider it.

Show

Darby Felton added a comment - 31/Jan/08 8:49 AM Unfortunately, I cannot use your patch until you have signed a Contributor License Agreement, but I think I can figure it out independently. Once you've signed the CLA, you can work on just about anything you like! Please consider it.

Hide

Permalink

Fabrizio Balliano added a comment - 31/Jan/08 8:51 AM

i didn't know about the CLA, i'll do that but it you can take a look at the patch cause anyway it's really simple

Show

Fabrizio Balliano added a comment - 31/Jan/08 8:51 AM i didn't know about the CLA, i'll do that but it you can take a look at the patch cause anyway it's really simple

Hide

Permalink

Darby Felton added a comment - 31/Jan/08 8:58 AM

Please check out SVN r7728, and let me know if this resolves the issue for you. Thanks!

Show

Darby Felton added a comment - 31/Jan/08 8:58 AM Please check out SVN r7728, and let me know if this resolves the issue for you. Thanks!

Hide

Permalink

Fabrizio Balliano added a comment - 31/Jan/08 9:07 AM

ok thank you, seems to work fine!
i think you can close the bug

Show

Fabrizio Balliano added a comment - 31/Jan/08 9:07 AM ok thank you, seems to work fine!

i think you can close the bug

Hide

Permalink

Darby Felton added a comment - 31/Jan/08 9:11 AM

Excellent! I'll mark this as fixed for the next minor release until I merge the changes over to the release-1.0 branch, so they can be in the upcoming 1.0.4 release, too.

Show

Darby Felton added a comment - 31/Jan/08 9:11 AM Excellent! I'll mark this as fixed for the next minor release until I merge the changes over to the release-1.0 branch, so they can be in the upcoming 1.0.4 release, too.

Hide

Permalink

Darby Felton added a comment - 31/Jan/08 9:43 AM

Fixed for 1.0.4 with SVN 7730.

Show

Darby Felton added a comment - 31/Jan/08 9:43 AM Fixed for 1.0.4 with SVN 7730.

People

Assignee:

Darby Felton

Reporter:

Fabrizio Balliano

Vote (1)

Watch (2)

Dates

Created:

11/Dec/07 12:20 PM

Updated:

26/Feb/08 12:55 PM

Resolved:

31/Jan/08 9:11 AM