Zend Framework

Promote Zend_Validate_Barcode and friends to core for release

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.5.0
  • Component/s: Zend_Validate
  • Labels:
    None
  • Fix Version Priority:
    Nice to Have

Description

Once unit testing for each file of the component reaches 80% LOC coverage and there exists satisfactory DocBook documentation for the APIs, the Zend_Validate_Barcode component needs to be promoted to core (i.e., moved to trunk with unit tests and documentation integrated).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wil Sinclair added a comment -

Andries, what is the status of Zend_Validate_Barcode? Should it be included in the preview release?

Show
Wil Sinclair added a comment - Andries, what is the status of Zend_Validate_Barcode? Should it be included in the preview release?
Hide
Permalink
Andries Seutens added a comment -

Wil, everything besides DocBook documentation is done.

Show
Andries Seutens added a comment - Wil, everything besides DocBook documentation is done.
Hide
Permalink
Andries Seutens added a comment -

Documentation is done, ready to promote to core.

Show
Andries Seutens added a comment - Documentation is done, ready to promote to core.
Hide
Permalink
Darby Felton added a comment -

We should have some deterministic method to arrive on constant values used in the Zend_Validate_* classes. See ZF-2397 for more information. I'm not sure which approach would be best, but we should pick something. For the short term, I suggest the following:

Zend_Validate_Barcode_UpcA::INVALID = 'invalid';
Zend_Validate_Barcode_UpcA::INVALID_LENGTH = 'invalidLength';
(and similarly for Zend_Validate_Barcode_Ean13)

The questions in my mind are whether or not to "mirror" the constant names with the values, and whether or not to include "namespaces", such as in the following:

Zend_Validate_Barcode_UpcA::INVALID = 'Zend_Validate_Barcode_UpcA::INVALID';
Show
Darby Felton added a comment - We should have some deterministic method to arrive on constant values used in the Zend_Validate_* classes. See ZF-2397 for more information. I'm not sure which approach would be best, but we should pick something. For the short term, I suggest the following: 
Zend_Validate_Barcode_UpcA::INVALID = 'invalid';
Zend_Validate_Barcode_UpcA::INVALID_LENGTH = 'invalidLength';
(and similarly for Zend_Validate_Barcode_Ean13)
The questions in my mind are whether or not to "mirror" the constant names with the values, and whether or not to include "namespaces", such as in the following: 
Zend_Validate_Barcode_UpcA::INVALID = 'Zend_Validate_Barcode_UpcA::INVALID';
Hide
Permalink
Andries Seutens added a comment -

I resolved this in r8210

Show
Andries Seutens added a comment - I resolved this in r8210
Hide
Permalink
Darby Felton added a comment -

Fixed for next minor release with SVN r8211.

Show
Darby Felton added a comment - Fixed for next minor release with SVN r8211.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.