ZF-2336: Promote Zend_Validate_Barcode and friends to core for release

Issue Type:
Task
Created:
2007-12-19T13:30:00.000+0000
Last Updated:
2008-03-21T16:25:31.000+0000
Status:
Resolved
Fix version(s):
  • 1.5.0 (17/Mar/08)
Reporter:
Darby Felton (darby)
Assignee:
Darby Felton (darby)
Tags:
  • Zend_Validate
Related issues:
Attachments:

Description

Once unit testing for each file of the component reaches 80% LOC coverage and there exists satisfactory DocBook documentation for the APIs, the Zend_Validate_Barcode component needs to be promoted to core (i.e., moved to trunk with unit tests and documentation integrated).

Comments

Posted by Wil Sinclair (wil) on 2008-01-22T22:34:09.000+0000

Andries, what is the status of Zend_Validate_Barcode? Should it be included in the preview release?

Posted by Andries Seutens (andries) on 2008-01-23T01:35:35.000+0000

Wil, everything besides DocBook documentation is done.

Posted by Andries Seutens (andries) on 2008-02-19T14:24:11.000+0000

Documentation is done, ready to promote to core.

Posted by Darby Felton (darby) on 2008-02-19T15:06:15.000+0000

We should have some deterministic method to arrive on constant values used in the {{Zend_Validate_*}} classes. See [ZF-2397] for more information. I'm not sure which approach would be best, but we should pick something. For the short term, I suggest the following:


Zend_Validate_Barcode_UpcA::INVALID = 'invalid';
Zend_Validate_Barcode_UpcA::INVALID_LENGTH = 'invalidLength';
(and similarly for Zend_Validate_Barcode_Ean13)

The questions in my mind are whether or not to "mirror" the constant names with the values, and whether or not to include "namespaces", such as in the following:


Zend_Validate_Barcode_UpcA::INVALID = 'Zend_Validate_Barcode_UpcA::INVALID';

Posted by Andries Seutens (andries) on 2008-02-20T08:10:57.000+0000

I resolved this in r8210

Posted by Darby Felton (darby) on 2008-02-20T08:31:47.000+0000

Fixed for next minor release with SVN r8211.