Zend Framework

Wrong variable name in Zend_Controller_Request_Http::setParam()

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.3
  • Fix Version/s: 1.0.4
  • Component/s: Zend_Controller
  • Labels:
    None
  • Fix Version Priority:
    Must Have

Description

Variable $keyName is never used. Should be $key (or the other way around):

public function setParam($key, $value)
    {
        $keyName = (null !== ($alias = $this->getAlias($key))) ? $alias : $key;

        parent::setParam($key, $value);
        return $this;
    }

Activity

Hide
Marc Jakubowski added a comment -

Additionally there seems to be no test that covers the case of aliasing a key and setting a parameter for it.

Show
Marc Jakubowski added a comment - Additionally there seems to be no test that covers the case of aliasing a key and setting a parameter for it.
Hide
Michal Minicki added a comment -

Fixed in trunk as well as in release branch. Good catch.

Show
Michal Minicki added a comment - Fixed in trunk as well as in release branch. Good catch.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: