ZF-2455: Wrong variable name in Zend_Controller_Request_Http::setParam()

Issue Type:
Bug
Created:
2008-01-18T09:28:25.000+0000
Last Updated:
2008-02-26T12:56:06.000+0000
Status:
Resolved
Fix version(s):
  • 1.0.4 (26/Feb/08)
Reporter:
Marc Jakubowski (octavian)
Assignee:
Michal Minicki (martel)
Tags:
  • Zend_Controller
Related issues:
Attachments:

Description

Variable $keyName is never used. Should be $key (or the other way around):


    public function setParam($key, $value)
    {
        $keyName = (null !== ($alias = $this->getAlias($key))) ? $alias : $key;

        parent::setParam($key, $value);
        return $this;
    }

Comments

Posted by Marc Jakubowski (octavian) on 2008-01-18T10:02:30.000+0000

Additionally there seems to be no test that covers the case of aliasing a key and setting a parameter for it.

Posted by Michal Minicki (martel) on 2008-01-29T08:40:09.000+0000

Fixed in trunk as well as in release branch. Good catch.