[#ZF-2499] Consumer::verify() could be more verbose. - Zend Framework Issue Tracker

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.5.3
Fix Version/s: 1.6.0
Component/s: Zend_OpenId
Labels:
None

Fix Version Priority:
Nice to Have

Description

Consumer::verify() can return false in 11 different places. It would easily be my favorite OpenID library if it returned an error code or threw an exception instead of just returning false. This would make implementing and debugging consumer/provider code much friendlier.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Steven Osborn added a comment - 25/Jan/08 10:35 PM

I'm not sure how feasible it would be, but could verify possibly return Zend_Auth_Result?

Show

Steven Osborn added a comment - 25/Jan/08 10:35 PM I'm not sure how feasible it would be, but could verify possibly return Zend_Auth_Result?

Hide

Permalink

Luke Crouch added a comment - 14/Apr/08 9:34 AM

it should also throw a Zend_OpenId_Exception in the places where it currently return false.

Show

Luke Crouch added a comment - 14/Apr/08 9:34 AM it should also throw a Zend_OpenId_Exception in the places where it currently return false.

Hide

Permalink

Dmitry Stogov added a comment - 16/Jul/08 2:06 AM

Now Zend_OpenId_Consumer::getError() may return explanation in case of login(), check() or verify() failure.

Show

Dmitry Stogov added a comment - 16/Jul/08 2:06 AM Now Zend_OpenId_Consumer::getError() may return explanation in case of login(), check() or verify() failure.

Hide

Permalink

Wil Sinclair added a comment - 02/Sep/08 10:38 AM

Updating for the 1.6.0 release.

Show

Wil Sinclair added a comment - 02/Sep/08 10:38 AM Updating for the 1.6.0 release.

People

Assignee:

Dmitry Stogov

Reporter:

Steven Osborn

Vote (4)

Watch (2)

Dates

Created:

25/Jan/08 3:41 PM

Updated:

02/Sep/08 10:38 AM

Resolved:

16/Jul/08 2:06 AM

Time Tracking

Estimated:

Remaining:

Logged:

Not Specified