ZF-2499: Consumer::verify() could be more verbose.

Issue Type:
Improvement
Created:
2008-01-25T15:41:33.000+0000
Last Updated:
2008-09-02T10:38:58.000+0000
Status:
Resolved
Fix version(s):
  • 1.6.0 (02/Sep/08)
Reporter:
Steven Osborn (steve918)
Assignee:
Dmitry Stogov (dmitry)
Tags:
  • Zend_OpenId
Related issues:
Attachments:

Description

Consumer::verify() can return false in 11 different places. It would easily be my favorite OpenID library if it returned an error code or threw an exception instead of just returning false. This would make implementing and debugging consumer/provider code much friendlier.

Comments

Posted by Steven Osborn (steve918) on 2008-01-25T22:35:53.000+0000

I'm not sure how feasible it would be, but could verify possibly return Zend_Auth_Result?

Posted by Luke Crouch (lcrouch) on 2008-04-14T09:34:31.000+0000

it should also throw a Zend_OpenId_Exception in the places where it currently return false.

Posted by Dmitry Stogov (dmitry) on 2008-07-16T02:06:55.000+0000

Now Zend_OpenId_Consumer::getError() may return explanation in case of login(), check() or verify() failure.

Posted by Wil Sinclair (wil) on 2008-09-02T10:38:58.000+0000

Updating for the 1.6.0 release.