Zend Framework

Wrong encoded of the subject, if the subject is longer than Zend_Mime::LINELENGTH.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 1.0.3
  • Fix Version/s: None
  • Component/s: Zend_Mail
  • Labels:
    None

Description

In Zend_Mail::_encodeHeader() and Zend_Mail::setSubject().

Now, it is:
=?utf-8?Q?mikespook=20=E9=82=80=E8=AB=8B=E6=82=A8=E9=80=B2=E5=85=A5=20ecbattle.net=20=E7=?=9A=84=E4=B8=96=E7=95=8C=E5=85=A7?=

But should be:
=?utf-8?Q?mikespook=20=E9=82=80=E8=AB=8B=E6=82=A8=E9=80=B2=E5=85=A5=20ecbattle.net=20=E7=?=
=?utf-8?Q?9A=84=E4=B8=96=E7=95=8C=E5=85=A7?=

And if I modify the code in Zend/Mail.php line: 392.

protected function _encodeHeader($value)
{
if (Zend_Mime::isPrintable($value)) { return $value; } else { $quotedValue = Zend_Mime::encodeQuotedPrintable($value); $quotedValue = str_replace(array('?', ' '), array('=3F', '=20'), $quotedValue); return '=?' . $this->_charset . '?Q?' . $quotedValue . '?='; }
}

to:

protected function _encodeHeader($value)
{
if (Zend_Mime::isPrintable($value)) { return $value; } } else { $quotedValue = Zend_Mime::encodeQuotedPrintable($value, 200); $quotedValue = str_replace(array('?', ' '), array('=3F', '=20'), $quotedValue); return '=?' . $this->_charset . '?Q?' . $quotedValue . '?='; }
}

there will be no problem. but if it is longer than 200, the subject will be showed hash.

Issue Links

This issue duplicates:
ZF-1688 Long header lines containing non-printable characters are corrupted Critical Resolved
This issue is related to:
ZF-3912 Incorrect encoding of 'subject' in Chinese e-mail, sent with Zend_Mail Critical Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Xing Xing added a comment -

In the version 1.5, it also has this issue.

Show
Xing Xing added a comment - In the version 1.5, it also has this issue.
Hide
Permalink
Ovidiu Curcan added a comment -

I ran into the same probkem while trying to send a newsletter. I came up with a quick & dirty fix (see below). It's a bit of a hack and it only works for the subject (not for other headers). Problems go deeper.

Patch to be applied agains ZF 1.0.3: 

--- Zend/Mail.php	2007-09-08 17:59:21.000000000 +0300
+++ Zend/Mail.php	2008-02-17 13:12:32.000000000 +0200
@@ -389,8 +389,9 @@
       if (Zend_Mime::isPrintable($value)) {
           return $value;
       } else {
-          $quotedValue = Zend_Mime::encodeQuotedPrintable($value);
+          $quotedValue = Zend_Mime::encodeQuotedPrintable($value, 60);
           $quotedValue = str_replace(array('?', ' '), array('=3F', '=20'), $quotedValue);
+          $quotedValue = str_replace("=\n", "?=\n=?". $this->_charset . '?Q?', $quotedValue);
           return '=?' . $this->_charset . '?Q?' . $quotedValue . '?=';
       }
     }
@@ -577,7 +578,14 @@
         if ($this->_subject === null) {
             $subject = strtr($subject,"\r\n\t",'???');
             $this->_subject = $this->_encodeHeader($subject);
-            $this->_storeHeader('Subject', $this->_subject);
+            $subjectPieces = explode("\n", $this->_subject);
+            $this->_storeHeader('Subject', $subjectPieces[0]);
+            unset($subjectPieces[0]);
+            if ($subjectPieces) {
+                foreach ($subjectPieces as $piece) {
+                    $this->_storeHeader('Subject', $piece, true);
+                }
+            }
         } else {
             throw new Zend_Mail_Exception('Subject set twice');
         }
Show
Ovidiu Curcan added a comment - I ran into the same probkem while trying to send a newsletter. I came up with a quick & dirty fix (see below). It's a bit of a hack and it only works for the subject (not for other headers). Problems go deeper. Patch to be applied agains ZF 1.0.3: 
--- Zend/Mail.php	2007-09-08 17:59:21.000000000 +0300
+++ Zend/Mail.php	2008-02-17 13:12:32.000000000 +0200
@@ -389,8 +389,9 @@
       if (Zend_Mime::isPrintable($value)) {
           return $value;
       } else {
-          $quotedValue = Zend_Mime::encodeQuotedPrintable($value);
+          $quotedValue = Zend_Mime::encodeQuotedPrintable($value, 60);
           $quotedValue = str_replace(array('?', ' '), array('=3F', '=20'), $quotedValue);
+          $quotedValue = str_replace("=\n", "?=\n=?". $this->_charset . '?Q?', $quotedValue);
           return '=?' . $this->_charset . '?Q?' . $quotedValue . '?=';
       }
     }
@@ -577,7 +578,14 @@
         if ($this->_subject === null) {
             $subject = strtr($subject,"\r\n\t",'???');
             $this->_subject = $this->_encodeHeader($subject);
-            $this->_storeHeader('Subject', $this->_subject);
+            $subjectPieces = explode("\n", $this->_subject);
+            $this->_storeHeader('Subject', $subjectPieces[0]);
+            unset($subjectPieces[0]);
+            if ($subjectPieces) {
+                foreach ($subjectPieces as $piece) {
+                    $this->_storeHeader('Subject', $piece, true);
+                }
+            }
         } else {
             throw new Zend_Mail_Exception('Subject set twice');
         }
Hide
Permalink
Wil Sinclair added a comment -

Please evaluate and categorize/assign as necessary.

Show
Wil Sinclair added a comment - Please evaluate and categorize/assign as necessary.
Hide
Permalink
James Dempster added a comment -

From what I could work out, a problem with encoding occurs when the subject line is greater than 75 chars and UTF8 chars of 2 or more bytes are being used. The subject line then needs to be split on to multiple lines if this split occurs in the middle of a quoted printable character i.e. between byte one and two the subject line breaks.

The easiest solution would be to use php iconv_mime_encode, but I found this to have a problem for quoted printable (Q Encoded) subject lines that where quote long. This is a bug in php it's self.

I've supplied a patch which is as far as I've gotten with the problem so far. I've tried to reproduce what iconv_mimie_encode would do for the Q encoding scheme. I think more evaluation testing and input is needed.

Also I've started to make the encoding technique usable by addTo for users whom have an alias in UTF8 encoded characters.

I've so far tested that this works with Thunderbird and Gmail (with what I understand the standards to be).

More feedback please.

Show
James Dempster added a comment - From what I could work out, a problem with encoding occurs when the subject line is greater than 75 chars and UTF8 chars of 2 or more bytes are being used. The subject line then needs to be split on to multiple lines if this split occurs in the middle of a quoted printable character i.e. between byte one and two the subject line breaks. The easiest solution would be to use php iconv_mime_encode, but I found this to have a problem for quoted printable (Q Encoded) subject lines that where quote long. This is a bug in php it's self. I've supplied a patch which is as far as I've gotten with the problem so far. I've tried to reproduce what iconv_mimie_encode would do for the Q encoding scheme. I think more evaluation testing and input is needed. Also I've started to make the encoding technique usable by addTo for users whom have an alias in UTF8 encoded characters. I've so far tested that this works with Thunderbird and Gmail (with what I understand the standards to be). More feedback please.
Hide
Permalink
Adam Myszak added a comment -

hello.
In my opinion the bug is in the '_storeHeader()' method of Zend_Mail class.
I don't know why is there a instruction: $value = strtr($value,"\r\n\t",'???'); ?
The specification of ARPA (RFC 2822) don't accept char '?' for divide a header.
You should change that instruction to replace char '?' for another.

Show
Adam Myszak added a comment - hello. In my opinion the bug is in the '_storeHeader()' method of Zend_Mail class. I don't know why is there a instruction: $value = strtr($value,"\r\n\t",'???'); ? The specification of ARPA (RFC 2822) don't accept char '?' for divide a header. You should change that instruction to replace char '?' for another.

People

Vote (10)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.