ZF-2575: Typo in Zend_Http_Cookie documentation

Issue Type:
Docs: Problem
Created:
2008-02-05T09:54:53.000+0000
Last Updated:
2008-06-15T14:06:29.000+0000
Status:
Resolved
Fix version(s):
  • 1.0.4 (26/Feb/08)
Reporter:
Simone Carletti (weppos)
Assignee:
Simone Carletti (weppos)
Tags:
  • Zend_Http_Cookie
Related issues:
Attachments:

Description

Bug posted by Vladas Diržys on public mailing list.

{quote} I think there is an error in documentation.

http://framework.zend.com/manual/en/…

Example 17.22. and forward uses: $cookie = Zend_Http_Client('foo=two+words; ....);

but it should be: $cookie = Zend_Http_Cookie('foo=two+words; ....); {quote}

Comments

Posted by Simone Carletti (weppos) on 2008-02-05T10:05:44.000+0000

I suppose this is not the only one error.


$cookie = Zend_Http_Client('foo=two+words; domain=.example.com; path=/somedir; secure;');

should be


$cookie = Zend_Http_Client::fromString('foo=two+words; domain=.example.com; path=/somedir; secure;');

and the same for the other examples where the cookie is created directly from the raw header.

Posted by Simone Carletti (weppos) on 2008-02-05T10:14:08.000+0000

I attach a patch for both typo and ::fromString issues.

Posted by Thomas Weidner (thomas) on 2008-02-05T14:11:41.000+0000

If you are not able to fix this issue please reassign it to "unassigned" so anyone other which has permition is able to review and commit the changes.

Posted by Simone Carletti (weppos) on 2008-02-05T14:42:08.000+0000

Hi Thomas, I'm able to do this (I have SVN access and HTTP Cookies is a field I have enough knowledge to feel comfortable to made a change), I just wanted to take some time because I created the patch at office in a while and I wanted to double check it at home since it was a change to the main manual. :)

Posted by Simone Carletti (weppos) on 2008-02-05T14:42:54.000+0000

Fixed in r7815

Posted by Wil Sinclair (wil) on 2008-06-15T14:06:29.000+0000

Changing to comply with new IT coventions for components.