ZF-2825: Strict Standards error messages

Issue Type:
Coding Standards Violation
Created:
2008-03-07T09:51:26.000+0000
Last Updated:
2008-10-12T12:06:06.000+0000
Status:
Resolved
Fix version(s):
  • 1.6.2 (13/Oct/08)
Reporter:
Jeffrey Sambells (jeffrey)
Assignee:
Mickael Perraud (mikaelkael)
Tags:
  • Zend_Db
  • Zend_Db_Adapter_Oracle
Related issues:
Attachments:

Description

Strict Standards: Declaration of Zend_Db_Adapter_Pdo_Oci::quoteTableAs() should be compatible with that of Zend_Db_Adapter_Abstract::quoteTableAs() in /Zend/Db/Adapter/Pdo/Oci.php on line 341

Strict Standards: Declaration of Zend_Db_Adapter_Oracle::quoteTableAs() should be compatible with that of Zend_Db_Adapter_Abstract::quoteTableAs() in /Zend/Db/Adapter/Oracle.php on line 612

Comments

Posted by Thomas Weidner (thomas) on 2008-03-07T11:58:39.000+0000

Please give your PHP Version, ZF Version or ZF Revision for detailed reproduction.

Posted by Martin Hujer (mhujer) on 2008-03-16T09:08:27.000+0000

On current trunk (r8860), both declarations are OK. I've just looked the up in the code. But I haven't try to run some code on it.

Posted by Thomas Weidner (thomas) on 2008-03-16T13:19:49.000+0000

I have also viewed such failures when running UnitTests on the complete framework on Windows with the latest trunk yesterday.

Posted by Yannick Lyn Fatt (axle_foley00) on 2008-03-17T21:31:35.000+0000

I have also received a similar Strict Standards Error. I am using the following:

  • PHP Version: 5.2.5
  • ZF Version: 1.5

Posted by Wil Sinclair (wil) on 2008-03-25T20:44:00.000+0000

Please categorize/fix as needed.

Posted by Yannick Lyn Fatt (axle_foley00) on 2008-03-26T17:39:18.000+0000

To fix this issue a change similar to the one described in ZF-2628 needs to be made.

Also it may be worth noting that the docblock for the method quoteTableAs() in Zend_Db_Pdo_Oci.php needs to have the following parameter description added:

@param boolean $auto If true, heed the AUTO_QUOTE_IDENTIFIERS config option.

Hope that is helpful.

Posted by Yannick Lyn Fatt (axle_foley00) on 2008-03-26T17:55:14.000+0000

Correction: I meant Zend_Db_Adapter_Pdo_Oci.php and not Zend_Db_Pdo_Oci.php.

Posted by Mickael Perraud (mikaelkael) on 2008-10-03T13:15:56.000+0000

For Pdo_Oci fixed in SVN9537 For Oracle fixed in SVN11560