Zend Framework

value "0" is treated as empty

Details

  • Type: Patch Patch
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.5.0RC1
  • Fix Version/s: 1.5.2
  • Component/s: Zend_Form
  • Labels:
    None
  • Fix Version Priority:
    Must Have

Description

bug:

$form->addElement("text", "abc");
$form->abc->setLabel("please enter a zero")->setRequired(true);

this will be impossible

bug2:

$form->addElement("text", "abc");
$form->abc->setLabel("enter a number (1 to 100)")->addValidator("between", false, array(1, 100));

user enters a 0 and it's ok!

note: I typed the above bugs right here, so there might be some things spelled wrong etc...

fix:

Index: Form/Element.php
===================================================================
--- Form/Element.php	(revision 8741)
+++ Form/Element.php	(working copy)
@@ -1146,7 +1147,7 @@
         $this->setValue($value);
         $value = $this->getValue();
 
-        if (empty($value) && !$this->isRequired() && $this->getAllowEmpty()) {
+        if ($value === "" && !$this->isRequired() && $this->getAllowEmpty()) {
             return true;
         }
 
Index: Validate/NotEmpty.php
===================================================================
--- Validate/NotEmpty.php	(revision 8741)
+++ Validate/NotEmpty.php	(working copy)
@@ -59,7 +59,7 @@
 
         $this->_setValue($valueString);
 
-        if (empty($value)) {
+        if ($value === "") {
             $this->_error();
             return false;
         }

// edit, new:

Index: Form/Element.php
===================================================================
--- Form/Element.php	(revision 8819)
+++ Form/Element.php	(working copy)
@@ -407,7 +407,7 @@
     public function setName($name)
     {
         $name = $this->filtername($name);
-        if (('0' !== $name) && empty($name)) {
+        if ($name === '') {
             require_once 'Zend/Form/Exception.php';
             throw new Zend_Form_Exception('Invalid name provided; must contain only valid variable characters and be non-empty');
         }

Issue Links

This issue is duplicated by:
ZF-3236 CLONE -value "0" is treated as empty Trivial Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vladimir Michailenko added a comment -

Also option in Zend_Form_Element_Multiselect with key "0" can not be marked as 'selected' via ->populate() or ->setValue(). For example: http://www.nabble.com/Zend_Form_Element_Multiselect-and-option-with-key-'0'-td15853694s16154.html

Show
Vladimir Michailenko added a comment - Also option in Zend_Form_Element_Multiselect with key "0" can not be marked as 'selected' via ->populate() or ->setValue(). For example: http://www.nabble.com/Zend_Form_Element_Multiselect-and-option-with-key-'0'-td15853694s16154.html
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Scheduling for final release

Show
Matthew Weier O'Phinney added a comment - Scheduling for final release
Hide
Permalink
Alexander Lanin added a comment -

I haven't gotten to multiselect yet, sry
maybe in a few days or matthew will fix it

Show
Alexander Lanin added a comment - I haven't gotten to multiselect yet, sry maybe in a few days or matthew will fix it
Hide
Permalink
Vladimir Michailenko added a comment -

Your fix NotEmpty validator does not handle empty array:
$value = array();

May be better just add 2 exceptions for ( http://php.net/empty ):
0 (0 as an integer)
"0" (0 as a string)

Show
Vladimir Michailenko added a comment - Your fix NotEmpty validator does not handle empty array: $value = array(); May be better just add 2 exceptions for ( http://php.net/empty ): 0 (0 as an integer) "0" (0 as a string)
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Re-scheduling for 1.5.1.

Show
Matthew Weier O'Phinney added a comment - Re-scheduling for 1.5.1.
Hide
Permalink
Wil Sinclair added a comment -

Resetting 'fix version priority' and 'fix version' to be re-evaluated for next release.

Show
Wil Sinclair added a comment - Resetting 'fix version priority' and 'fix version' to be re-evaluated for next release.
Hide
Permalink
Gregory Wilson added a comment -

Ran into the same issue here. No one on #zftalk knew anything about it either.

Show
Gregory Wilson added a comment - Ran into the same issue here. No one on #zftalk knew anything about it either.
Hide
Permalink
Alexander Lanin added a comment -

I'm verry sorry, but someone else will have to fix this as I don't have the time right now.
One note: empty() doesn't make sense, since all we need is to check for "" and array(), this are 2 "operations" instead of 7 with empty()

Show
Alexander Lanin added a comment - I'm verry sorry, but someone else will have to fix this as I don't have the time right now. One note: empty() doesn't make sense, since all we need is to check for "" and array(), this are 2 "operations" instead of 7 with empty()
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Scheduling for next mini release.

Show
Matthew Weier O'Phinney added a comment - Scheduling for next mini release.
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Resolved in trunk and 1.5 release branch

Show
Matthew Weier O'Phinney added a comment - Resolved in trunk and 1.5 release branch
Hide
Permalink
Vladimir Michailenko added a comment -

Version from trunk:

$this->addElement('select', 'parent_id', array(
'label' => 'Category',
'multiOptions' => array(
'0' => 'Root',
),
'attribs' => array(
'size' => 4,
),
'required' => true,
));

When I choose "Root" category I still get error... Zend_Validate_NotEmpty:

if (empty($value)) { $this->_error(); return false; }

php.net/empty:

The following things are considered to be empty:
"" (an empty string)
0 (0 as an integer) !!!
"0" (0 as a string) !!!
NULL
FALSE
array() (an empty array)
var $var; (a variable declared, but without a value in a class)

Show
Vladimir Michailenko added a comment - Version from trunk: $this->addElement('select', 'parent_id', array( 'label' => 'Category', 'multiOptions' => array( '0' => 'Root', ), 'attribs' => array( 'size' => 4, ), 'required' => true, )); When I choose "Root" category I still get error... Zend_Validate_NotEmpty: if (empty($value)) { $this->_error(); return false; } php.net/empty: The following things are considered to be empty: "" (an empty string) 0 (0 as an integer) !!! "0" (0 as a string) !!! NULL FALSE array() (an empty array) var $var; (a variable declared, but without a value in a class)
Hide
Permalink
Gregory Wilson added a comment -

Confirmed still an issue in 1.5.2 release.

Zend_Debug::dump(Zend_Validate::is('0', 'NotEmpty')); // false

Show
Gregory Wilson added a comment - Confirmed still an issue in 1.5.2 release. Zend_Debug::dump(Zend_Validate::is('0', 'NotEmpty')); // false
Hide
Permalink
Cole Snodgrass added a comment -

This is still an issue in 1.6.0rc1, I would reopen this issue but lack the ability.

<?php
require_once 'Zend/Version.php';
require_once 'Zend/Validate.php';

var_dump(Zend_Version::VERSION);
var_dump(Zend_Validate::is('1', 'NotEmpty'));
var_dump(Zend_Validate::is('0', 'NotEmpty'));

/*
Expected output:
string(3) "1.6"
bool(true)
bool(true)

Actual output:
string(3) "1.6"
bool(true)
bool(false)
*/
Show
Cole Snodgrass added a comment - This is still an issue in 1.6.0rc1, I would reopen this issue but lack the ability. 
<?php
require_once 'Zend/Version.php';
require_once 'Zend/Validate.php';

var_dump(Zend_Version::VERSION);
var_dump(Zend_Validate::is('1', 'NotEmpty'));
var_dump(Zend_Validate::is('0', 'NotEmpty'));

/*
Expected output:
string(3) "1.6"
bool(true)
bool(true)

Actual output:
string(3) "1.6"
bool(true)
bool(false)
*/
Hide
Permalink
Matthew Weier O'Phinney added a comment -

The modification was in Zend_Form. Zend_Validate still retains the old behavior, as this is correct in terms of how empty() works.
Please open a separate issue if you feel Zend_Validate_NotEmpty should be changed; be prepared to make a very good case for changing it.

Show
Matthew Weier O'Phinney added a comment - The modification was in Zend_Form. Zend_Validate still retains the old behavior, as this is correct in terms of how empty() works. Please open a separate issue if you feel Zend_Validate_NotEmpty should be changed; be prepared to make a very good case for changing it.

People

Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
15m
Original Estimate - 15 minutes
Remaining:
15m
Remaining Estimate - 15 minutes
Logged:
Not Specified
Time Spent - Not Specified
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.