[#ZF-2870] HtmlList doesn't pass on the escape parameter for sub lists - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.5.0
Fix Version/s: 1.5.2
Component/s: Zend_View
Labels:
None

Fix Version Priority:
Must Have

Description

The HtmlList helper accepts an 'escape' parameter to determine whether or not to escape given list before rendering. But when it recursively calls itself to render sub lists, it doesn't pass on the escape parameter so sub lists are always escaped.

Issue Links

This issue is related to:
ZF-2527	HtmlList escape works only for one dimension

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Martin Hujer added a comment - 16/Mar/08 6:09 AM

Duplicity of ~~ZF-2527~~

Show

Martin Hujer added a comment - 16/Mar/08 6:09 AM Duplicity of ~~ZF-2527~~

Hide

Permalink

Martin Hujer added a comment - 16/Mar/08 6:16 AM

It is already fixed in 1.5.0RC3 and in trunk.

Show

Martin Hujer added a comment - 16/Mar/08 6:16 AM It is already fixed in 1.5.0RC3 and in trunk.

Hide

Permalink

Martin Hujer added a comment - 16/Mar/08 6:38 AM

Sorry, it was a mistake, I got confused with ~~ZF-2527~~.

This is not fixed.

The code between 58-69 need some comments, It is not 100%-ly clean; especially:

if (5 < strlen($list)) {

58:        foreach ($items as $item) {
            if (!is_array($item)) {
                if ($escape) $item = $this->view->escape($item); 
                $list .= '<li>' . $item . '</li>';
            } else {
                if (5 < strlen($list)) {
                    $list = substr($list, 0, strlen($list) - 5) . $this->htmlList($item, $ordered, $attribs, $escape) . '</li>';
                } else {
                    $list .= '<li>' . $this->htmlList($item, $ordered) . '</li>';
                }
            }
        }

Show

Martin Hujer added a comment - 16/Mar/08 6:38 AM Sorry, it was a mistake, I got confused with ~~ZF-2527~~. This is not fixed. The code between 58-69 need some comments, It is not 100%-ly clean; especially:

if (5 < strlen($list)) {

58:        foreach ($items as $item) {
            if (!is_array($item)) {
                if ($escape) $item = $this->view->escape($item); 
                $list .= '<li>' . $item . '</li>';
            } else {
                if (5 < strlen($list)) {
                    $list = substr($list, 0, strlen($list) - 5) . $this->htmlList($item, $ordered, $attribs, $escape) . '</li>';
                } else {
                    $list .= '<li>' . $this->htmlList($item, $ordered) . '</li>';
                }
            }
        }

Hide

Permalink

Martin Hujer added a comment - 16/Mar/08 6:39 AM

It is related, but doesn't duplicate it.

Show

Martin Hujer added a comment - 16/Mar/08 6:39 AM It is related, but doesn't duplicate it.

Hide

Permalink

Harro van der Klauw added a comment - 16/Mar/08 6:48 AM

The Unit test for this item fails to notice this bug because all the item arrays build there all start with a single value, the issue only occurs when the first item in the array is also an array.

Issue ~~ZF-2527~~ has a diff attached that did properly fix the problem.
Line 66 needs to have the attribs and escape added.

Show

Harro van der Klauw added a comment - 16/Mar/08 6:48 AM The Unit test for this item fails to notice this bug because all the item arrays build there all start with a single value, the issue only occurs when the first item in the array is also an array. Issue ~~ZF-2527~~ has a diff attached that did properly fix the problem. Line 66 needs to have the attribs and escape added.

Hide

Permalink

Wil Sinclair added a comment - 25/Mar/08 8:33 PM

Please categorize/fix as needed.

Show

Wil Sinclair added a comment - 25/Mar/08 8:33 PM Please categorize/fix as needed.

Hide

Permalink

Wil Sinclair added a comment - 25/Mar/08 10:06 PM

Resetting 'fix version priority' and 'fix version' to be re-evaluated for next release.

Show

Wil Sinclair added a comment - 25/Mar/08 10:06 PM Resetting 'fix version priority' and 'fix version' to be re-evaluated for next release.

Hide

Permalink

Matthew Weier O'Phinney added a comment - 22/Apr/08 11:25 AM

Scheduling for next mini release.

Show

Matthew Weier O'Phinney added a comment - 22/Apr/08 11:25 AM Scheduling for next mini release.

Hide

Permalink

Matthew Weier O'Phinney added a comment - 02/May/08 12:19 PM

Resolved in trunk and 1.5 release branch

Show

Matthew Weier O'Phinney added a comment - 02/May/08 12:19 PM Resolved in trunk and 1.5 release branch

People

Assignee:

Matthew Weier O'Phinney

Reporter:

Amr Mostafa

Vote (2)

Watch (2)

Dates

Created:

12/Mar/08 11:51 AM

Updated:

05/May/08 11:44 AM

Resolved:

02/May/08 12:19 PM

Time Tracking

Estimated:

Remaining:

Logged:

Not Specified