Zend Framework

HtmlList helper coding standards

Details

  • Type: Coding Standards Violation Coding Standards Violation
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.5.0
  • Fix Version/s: 1.5.2
  • Component/s: Zend_View
  • Labels:
    None

Description

Zend_View_Helper_HtmlList doesn't follow coding standards here:

Index: I:/xampp/php/PEAR/Zend15/library/Zend/View/Helper/HtmlList.php
===================================================================
--- I:/xampp/php/PEAR/Zend15/library/Zend/View/Helper/HtmlList.php	(revision 8854)
+++ I:/xampp/php/PEAR/Zend15/library/Zend/View/Helper/HtmlList.php	(working copy)
@@ -57,7 +57,9 @@
 
         foreach ($items as $item) {
             if (!is_array($item)) {
-                if ($escape) $item = $this->view->escape($item); 
+                if ($escape) {
+                    $item = $this->view->escape($item);
+                }
                 $list .= '<li>' . $item . '</li>';
             } else {
                 if (5 < strlen($list)) {

Activity

Hide
Wil Sinclair added a comment -

Please categorize/fix as needed.

Show
Wil Sinclair added a comment - Please categorize/fix as needed.
Hide
Wil Sinclair added a comment -

Resetting 'fix version priority' and 'fix version' to be re-evaluated for next release.

Show
Wil Sinclair added a comment - Resetting 'fix version priority' and 'fix version' to be re-evaluated for next release.
Hide
Matthew Weier O'Phinney added a comment -

This was fixed when resolving other issues for 1.5.2.

Show
Matthew Weier O'Phinney added a comment - This was fixed when resolving other issues for 1.5.2.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: