ZF-2890: HtmlList helper coding standards

Issue Type:
Coding Standards Violation
Created:
2008-03-16T06:46:48.000+0000
Last Updated:
2008-05-09T12:13:21.000+0000
Status:
Resolved
Fix version(s):
  • 1.5.2 (15/May/08)
Reporter:
Martin Hujer (mhujer)
Assignee:
Ralph Schindler (ralph)
Tags:
  • Zend_View
Related issues:
Attachments:

Description

Zend_View_Helper_HtmlList doesn't follow coding standards here:


Index: I:/xampp/php/PEAR/Zend15/library/Zend/View/Helper/HtmlList.php
===================================================================
--- I:/xampp/php/PEAR/Zend15/library/Zend/View/Helper/HtmlList.php  (revision 8854)
+++ I:/xampp/php/PEAR/Zend15/library/Zend/View/Helper/HtmlList.php  (working copy)
@@ -57,7 +57,9 @@
 
         foreach ($items as $item) {
             if (!is_array($item)) {
-                if ($escape) $item = $this->view->escape($item); 
+                if ($escape) {
+                    $item = $this->view->escape($item);
+                }
                 $list .= '' . $item . '';
             } else {
                 if (5 < strlen($list)) {

Comments

Posted by Wil Sinclair (wil) on 2008-03-25T20:33:30.000+0000

Please categorize/fix as needed.

Posted by Wil Sinclair (wil) on 2008-03-25T22:06:45.000+0000

Resetting 'fix version priority' and 'fix version' to be re-evaluated for next release.

Posted by Matthew Weier O'Phinney (matthew) on 2008-05-09T12:13:21.000+0000

This was fixed when resolving other issues for 1.5.2.