ZF-2912: ContextSwitch constructor has a parameter for helper configuration; no parameters should be specified

Issue Type:
Bug
Created:
2008-03-18T10:22:37.000+0000
Last Updated:
2008-07-25T10:02:27.000+0000
Status:
Resolved
Fix version(s):
  • 1.5.3 (28/Jul/08)
Reporter:
Steven Reed (stevereed)
Assignee:
Matthew Weier O'Phinney (matthew)
Tags:
  • Zend_Controller
Related issues:
Attachments:

Description

Zend_Controller_Action_Helper_ContextSwitch class constructor takes one parameter; as the helper broker doesn't allow for constructor parameters when it instantiates helpers, it should be removed. The parameter is not used in the method body.

Comments

Posted by Wil Sinclair (wil) on 2008-03-25T20:41:11.000+0000

Please categorize/fix as needed.

Posted by Steven Reed (stevereed) on 2008-04-03T04:57:23.000+0000

A small clarification: If you wished to instantiate the ContextSwitch helper and pass it to the helper broker manually, you could of course specify a parameter to its constructor for configuration. Either setOptions() or setConfig() should be called if the parameter is not null.

Posted by Matthew Weier O'Phinney (matthew) on 2008-04-22T13:23:31.000+0000

You can instantiate the helper manually and pass it to the helper broker; allowing for options in the constructor simply simplifies this to a single step.

Not an issue.

Posted by Steven Reed (stevereed) on 2008-04-23T05:51:07.000+0000

An issue still exists however where by the constructor parameter {{$options}} is not used in the constructor body. If it is not null it should be passed to either {{setOptions()}} or {{setConfig()}}.

Posted by Matthew Weier O'Phinney (matthew) on 2008-04-23T06:57:14.000+0000

Re-opening due to user feedback.

Posted by Matthew Weier O'Phinney (matthew) on 2008-05-09T11:19:38.000+0000

Scheduling for next mini release.

Posted by Matthew Weier O'Phinney (matthew) on 2008-07-25T10:02:27.000+0000

Fixed in trunk and 1.5 and 1.6 release branches