[#ZF-2980] compareDate() results in many calls to isYearLeapYear() - Zend Framework Issue Tracker

Details

Type: Improvement
Status: Resolved
Priority: Trivial
Resolution: Fixed
Affects Version/s: 1.5.1
Fix Version/s: 1.6.0
Component/s: Zend_Date
Labels:
None

Description

I was profiling my app and noticed what looks like an excessive number of calls to this function.

This simple code results in 4018 calls to isYearLeapYear()

$s = new Zend_Date('311207', 'ddMMyy');
$e = new Zend_Date('090108', 'ddMMyy');
$s->compareDate($e);

I'm raising this just in case a mistake was made. Could be no issue.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

cachegrind.out.4219244990.tar.gz

27/Mar/08 5:54 AM

29 kB

Karol Grecki

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Thomas Weidner added a comment - 27/Mar/08 10:47 AM

No this is NO problem or bug or mistake.

You entered the date "31.December. 7 after Christ"... the year 0007 and not 2007.
Now the timestamp is calculated for the year where christ was 7 years old.

PHP can only handle dates until 1914. (negative timestamps).
Zend_Date builds the timestamp for this date himself. The calculation for real historical or even astronomical dates is complicated and is done mathematically where the mentioned function is one part of this process.

When you look into the manual there is a sentence about "historical" or "astronomical" dates and performance.

Show

Thomas Weidner added a comment - 27/Mar/08 10:47 AM No this is NO problem or bug or mistake. You entered the date "31.December. 7 after Christ"... the year 0007 and not 2007. Now the timestamp is calculated for the year where christ was 7 years old. PHP can only handle dates until 1914. (negative timestamps). Zend_Date builds the timestamp for this date himself. The calculation for real historical or even astronomical dates is complicated and is done mathematically where the mentioned function is one part of this process. When you look into the manual there is a sentence about "historical" or "astronomical" dates and performance.

Hide

Permalink

Karol Grecki added a comment - 27/Mar/08 11:08 AM

Actually I entered the year 2007 as 07 and it was parsed as I expcected

$s = new Zend_Date('311207', 'ddMMyy');
echo $s; //31 Dec 2007 00:00:00

Also after changing code to

$s = new Zend_Date('31122007', 'ddMMyyyy');
$e = new Zend_Date('09012008', 'ddMMyyyy');
$s->compareDate($e);

isYearLeapYear() is still called over 4000 times

Show

Karol Grecki added a comment - 27/Mar/08 11:08 AM Actually I entered the year 2007 as 07 and it was parsed as I expcected

$s = new Zend_Date('311207', 'ddMMyy');
echo $s; //31 Dec 2007 00:00:00

Also after changing code to

$s = new Zend_Date('31122007', 'ddMMyyyy');
$e = new Zend_Date('09012008', 'ddMMyyyy');
$s->compareDate($e);

isYearLeapYear() is still called over 4000 times

Hide

Permalink

Thomas Weidner added a comment - 27/Mar/08 11:12 AM

Review

Show

Thomas Weidner added a comment - 27/Mar/08 11:12 AM Review

Hide

Permalink

Thomas Weidner added a comment - 27/Mar/08 11:48 AM

Agreed

Fixed with SVN-9066... is 0 times called better for you ?

Show

Thomas Weidner added a comment - 27/Mar/08 11:48 AM Agreed

Fixed with SVN-9066... is 0 times called better for you ?

Hide

Permalink

Karol Grecki added a comment - 27/Mar/08 11:57 AM

Nice one, cheers

Show

Karol Grecki added a comment - 27/Mar/08 11:57 AM Nice one, cheers

Hide

Permalink

Wil Sinclair added a comment - 02/Sep/08 10:39 AM

Updating for the 1.6.0 release.

Show

Wil Sinclair added a comment - 02/Sep/08 10:39 AM Updating for the 1.6.0 release.

People

Assignee:

Thomas Weidner

Reporter:

Karol Grecki

Vote (0)

Watch (0)

Dates

Created:

27/Mar/08 5:53 AM

Updated:

02/Sep/08 10:39 AM

Resolved:

27/Mar/08 11:49 AM

Time Tracking

Estimated:

Remaining:

30m

Logged:

30m