ZF-3022: Zend_Controller_Action_Helper_Redirector goto() PHP5.3 unexpected T_GOTO

Issue Type:
Bug
Created:
2008-04-02T09:40:28.000+0000
Last Updated:
2008-09-02T10:39:06.000+0000
Status:
Resolved
Fix version(s):
  • 1.6.0 (02/Sep/08)
Reporter:
James Dempster (letssurf)
Assignee:
Matthew Weier O'Phinney (matthew)
Tags:
  • Zend_Controller
Related issues:
Attachments:

Description

I know PHP5.3 hasn't even entered RC stage, but I wanted to start using late static binding.

Certain keywords have been added to PHP5.3, for example goto.

Zend_Controller_Action_Helper_Redirector uses goto as a method name and so causes a parse error "Parse error: syntax error, unexpected T_GOTO, expecting T_STRING"

Comments

Posted by James Dempster (letssurf) on 2008-04-02T09:42:44.000+0000

I've attached a proposed patch to fix the problem.

It would still support backwards compatibility by using __call to catch any calls to the goto method, and then calls the new method gotoAction.

Posted by Wil Sinclair (wil) on 2008-04-18T16:21:27.000+0000

Please evaluate and categorize/assign as necessary.

Posted by Matthew Weier O'Phinney (matthew) on 2008-04-22T10:58:17.000+0000

Scheduling for next mini-release and assigning to Ralph.

Posted by Matthew Weier O'Phinney (matthew) on 2008-06-30T09:17:00.000+0000

Fixed in trunk in r 9838; merge commited to 1.5 release branch in 9839.

Posted by Wil Sinclair (wil) on 2008-09-02T10:39:06.000+0000

Updating for the 1.6.0 release.