ZF-3091: Zend_Validate_Hostname incorrect local network name errors
Description
Using the Zend_Validate_Hostname with the default setting of not allowing local hostnames will produce incorrect errors when given an invalid local network name such as machine_local:
- The isValid() method on line 413 checks if the hostname is a valid local network name and correctly sets an error if not.
- Regardless of the result above, line 418 does a check if local names are allowed at all and so also sets an error.
- The result is these errors, both of which cannot be correct simultaneously:
- 'machine_local' does not appear to be a valid local network name - 'machine_local' appears to be a local network name but local network names are not allowed
Attached is a patch to correct line 418 from
to
Comments
Posted by Joakim Nygård (jokke) on 2008-04-10T06:18:15.000+0000
Trivial patch to correct issue described
Posted by Joakim Nygård (jokke) on 2008-04-10T14:53:07.000+0000
Fixed in r9195
Posted by Darby Felton (darby) on 2008-04-22T08:44:18.000+0000
Marked as fixed for next minor release pending merge of changes to release-1.5 branch.
Posted by Joakim Nygård (jokke) on 2008-05-09T07:20:13.000+0000
Merged to 1.5 branch in r9432
Posted by Wil Sinclair (wil) on 2008-09-02T10:39:38.000+0000
Updating for the 1.6.0 release.