Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Won't Fix
-
Affects Version/s: 1.6.0RC2
-
Fix Version/s: None
-
Component/s: Zend_Db_Select
-
Labels:None
-
Fix Version Priority:Nice to Have
Description
As described in #ZF-3235 it would be desirable to have access to the source table information in a Zend_Db_Table_Select instance.
The current implementation sets the "from" information in the __toString() method, after which it's available in the $_parts array and thus accessible via getPart().
It would make sense to have the "from" information available in $_parts directly after the Zend_Db_Table_Select object has been instantiated.
Attached is a modified Zend_Db_Table_Select which provides an idea to a possible solution. There's a new method _setParts(), which loads some information into the $_parts array. This is copied from __toString().
Attachments
Issue Links
| This issue depends on: | ||||
| ZF-2546 | Zend_Db_Table_Select should include its own table in the FROM section |
|
|
|
| This issue is dependecy of: | ||||
| ZF-3719 | Using Zend_Db_Table_Select objects with Zend_Paginator throws exception "No table has been specified for the FROM clause" |
|
|
|
| This issue is duplicated by: | ||||
| ZF-5830 | Zend_Db_Table_Select doesn't allow use of $select->columns('..') |
|
|
|
| This issue is related to: | ||||
| ZF-3235 | Get $_info data from Zend_Db_Table_Select instance |
|
|
|
Activity
Attached is a patch that sets the FROM clause directly on instantiating the Zend_Db_Table_Select object. This is done in the setTable part:
public function setTable(Zend_Db_Table_Abstract $table) { $this->_adapter = $table->getAdapter(); $this->_info = $table->info(); $primary = $this->_info[Zend_Db_Table_Abstract::NAME]; $schema = $this->_info[Zend_Db_Table_Abstract::SCHEMA]; $this->from($primary, self::SQL_WILDCARD, $schema); return $this; }
The code used is directly copied from the assemble method, so it could be argued that some code there has become redundant.
I have tested the modified select query with Zend_Paginator and it now works the same as a Zend_Db_Select query. As far as I could find and run a unit test for this class (installing and configuring XDebug kinda messed with my PHPUnit's output) there don't seem to be any problems (at least no failed tests).
This issue should be fixed in time for ZF 1.6 RC1, so people can get the best Paginator experience 
public function setTable(Zend_Db_Table_Abstract $table) { $this->_adapter = $table->getAdapter(); $this->_info = $table->info(); $primary = $this->_info[Zend_Db_Table_Abstract::NAME]; $schema = $this->_info[Zend_Db_Table_Abstract::SCHEMA]; $this->from($primary, self::SQL_WILDCARD, $schema); return $this; }
Jurrien's patch has a minor BC problem (if I understand everything correctly):
Currently, if you select only some columns, then only those would be returned, since * is added before converting to string ONLY if no columns are selected.
With Jurrien's patch, * would always be selected, unless explicitly removed using reset(Zend_Db_Select::COLUMNS).
In addition to Jurrien's change, I propose:
- adding a protected variable $_wildcardSelectedByDefault. This would then get set to true in setTable() at the same time as ?$this->from($primary, self::SQL_WILDCARD, $schema)?
- override columns() to remove ?self::SQL_WILDCARD? from columns and set _wildcardSelectedByDefault to false if setting columns for the primary table and $_wildcardSelectedByDefault is true.
This way * is selected unless columns() is called explicitly, and the Zend_Db_Table_Select object always reflects the current "state" (columns that will actually be selected).
I will be testing this solution during the next week. If anyone has any other suggestions/worries, please speak 
- adding a protected variable $_wildcardSelectedByDefault. This would then get set to true in setTable() at the same time as ?$this->from($primary, self::SQL_WILDCARD, $schema)?
- override columns() to remove ?self::SQL_WILDCARD? from columns and set _wildcardSelectedByDefault to false if setting columns for the primary table and $_wildcardSelectedByDefault is true.
Please evaluate and fix/categorize as necessary.