History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: ZF-3369
Type: New Feature New Feature
Status: In Progress In Progress
Priority: Major Major
Assignee: Trevor Johns
Reporter: Darien Hager
Votes: 6
Watchers: 12
Operations

If you were logged in you would be able to see more operations.
Google issue summary
Zend Framework

Google Contacts API support

Created: 02/Jun/08 01:07 PM   Updated: 24/Mar/09 05:45 PM
Component/s: Zend_Gdata
Affects Version/s: 1.5.2
Fix Version/s: None

Time Tracking:
Issue & Sub-Tasks
Issue Only
Not Specified

File Attachments: 1. Text File zf_gcontacts_initial.patch (82 kb)

Image Attachments:

1. Gmail Rendering.jpg
(68 kb)

2. Test Contact through Zend_Gdata_Contacts code.jpg
(194 kb)

Tags:
Participants: Curt Larson, Darien Hager, Jeffrey Scudder, Ryan Boyd and Trevor Johns

Sub-Tasks  All   Open   

 Description  « Hide
This is more of a heads-up than a request.

I'm currently working on some code to work with the new Zend Contacts API for managing things like Gmail contacts. I anticipate having something in an alpha peer-review state sometime this week.

http://code.google.com/apis/contacts/

I'm starting this issue so I'll have somewhere to post the code and to "stake out" the area to avoid having multiple people unknowingly working on the same task.

Stuff that currently works:

  • Listing contacts
  • Emails
  • Phone data & subtype (mobile, pager, fax) information
  • IM data
  • Organization data
  • Label/categorization for data types
  • Altering primary e-mail
  • Notes about the current user


 All   Comments   Work Log   Change History   FishEye   Crucible      Sort Order: Ascending order - Click to sort in descending order
Darien Hager - 04/Jun/08 12:33 PM
I signed the indivdual CLA before, but this one is something on company time so as soon as I get a Corporate CLA done I'll post what I have. Current classes:

Contacts/Extension/Categorized.php (abstract superclass)
Contacts/Extension/Email.php
Contacts/Extension/Im.php
Contacts/Extension/Name.php
Contacts/Extension/Notes.php
Contacts/Extension/Organization.php
Contacts/Extension/OrgName.php
Contacts/Extension/OrgTitle.php
Contacts/Extension/PhoneNumber.php
Contacts/Extension/PostalAddress.php
Contacts/ListEntry.php
Contacts/ListFeed.php


Jeffrey Scudder - 04/Jun/08 03:22 PM
Very cool Darien, sounds like a fantastic start! I'd like to help in some way if you're interested. Unit tests, sample application, etc. Are there any data model classes that you need? I have some code for Contacts/Extension/GroupMembershipInfo.php and Deleted.php if you are interested.

Darien Hager - 04/Jun/08 04:12 PM
Thanks, I'm currently waiting on The Powers That Be to authorize me sending CLA application. Once I can post actual code things should be clearer.

I'm afraid my development model has been fairly haphazard, partially because this is my first time delving into the Gdata component works internally. So I don't have any unit tests. (How do you unit test against a monolithic external service anyway?) Right now the general structure is similar to the Calendar/ListEntry.php class.

Stuff I don't plan to implement any time soon:

  • Photos
  • Bulk updates (a broader issue than just Contacts)
  • Group or Membership data and queries

Misc concerns:


Darien Hager - 04/Jun/08 04:18 PM
What the test contact looks like in GMail...

Darien Hager - 04/Jun/08 04:21 PM
...Shows a GMail contact as retrieved and displayed by PHP code.

The [1] designates the primary e-mail. "

MyCat" is a custom category for information, parallel to "Work" and "Personal".

Phone numbers may have a subtype like "Fax".

For organizations, the title is in square brackets.


Darien Hager - 04/Jun/08 04:27 PM
Okay, so those last two screenshots are at least proof-of-concept. (Yes, the custom output is ugly, but it was easier when writing a bunch of throwaway echo statements.)

More musings and API uncertainties:

  • Can you have multiple "Fax" or "Mobile" phone numbers for a single category for a single contact? Right now there's no clientside code for checking that kind of situation.
  • It seems you can make a custom category called "work" that parallels the built-in "work" category. Is this a bug? How can we distinguish between them? The current implementation just assumes such name collision is not possible.
  • I haven't tested any sort of "advanced searching" or listing--just pulling back a small but complete list of test contacts.

Jeffrey Scudder - 10/Jun/08 01:58 PM
In answer to your three questions:
  • yes, it is possible to have multiple phone numbers with rel set to fax (http://schemas.google.com/g/2005#fax)
  • when you say that you are making a custom category, do you mean that you are adding an Atom category element to the entry, or did you mean you are using a different rel value on a phoneNumber element (for example)?
  • the query capabilities for the API are listed here: http://code.google.com/apis/contacts/reference.html#Parameters . The items in the first box should already be included inf you inherit from the Gdata query class, the second set will require some new code. Please let me know if the descriptions in the documentation aren't clear.

If you have any questions, please ask


Darien Hager - 10/Jun/08 02:59 PM
Thanks for your reply. I'm still bugging the appropriate folks for official permission to contribute the code.

What I had meant about categories is what you can do with Gmail: You start with "Work", "Personal" and "Other".

You can make custom categories like "Secret Identity" to hold a similar corresponding set of postal/im/email/phone data.

However, it seems you can also make custom categories which (from just looking at the XML) are indistinguishable from the built-in ones.

Improvements:

  • Added features to set the "primary" flag among sets of phone, IM, email, and postal values. (AFAIK the "primary e-mail" scope includes all email items in all categories, not just "Primary for Home" and "Primary For Work", etc.)
  • Listing categories in use for an entry (Home, Work, Personal, Foo)
  • Retrieving data objects by category label
  • Contacts-API-specific query options mostly coded

Darien Hager - 30/Jun/08 03:44 PM
Huzzah! Apparently a confluence of deadlines (some ending, some starting) have resulted in activity.

I anticipate having legally-postable svn diffs shortly. Hopefully in time for the 1.6 feature freeze. Mind you, my prior "anticipation" was misleading, but literally correct

Is there any particular branch or tag I should diff against? I'm currently working off of 1.5.2, although it shouldn't matter very much since most of the files are new.


Ryan Boyd - 30/Jun/08 04:13 PM
Hi Darien,

I appreciate all your hard work to get contacts support in. However, I don't know if we're going to have time to get this in before midnight tonight for the 1.6 feature freeze. I believe all code reviews/testing/docs/etc need to be complete by tonight. Given that ZF strives to maintain backwards compatibility, I don't think we really want to rush through this process.

Perhaps we should work on getting this checked into trunk later this week and then push forward to having it included in the 1.7 release (which Wil promises will come shortly after 1.6).

We can then post info in the Google Group for Contacts and get people to test it out before the release?

Cheers,
-Ryan


Darien Hager - 30/Jun/08 04:27 PM
Ah, so it's more than just a freeze on feature scope, then. Darn.

Regarding backwards-compatibility...

The only changes that are not entirely new files are convenience functions which can be moved elsewhere. I could submit a changeset which shouldn't affect anybody who isn't specifically trying the new API.


Ryan Boyd - 30/Jun/08 04:44 PM
Hi Darien,

Yea, I'd love to get this in ASAP, but I want to make sure it's done right. The note from Wil:
"Just a reminder that the feature-complete (that means all code, unit tests, and documentation) deadline for all contributions targeted for the 1.6 release is 6/30. "

Re backwards-compat:
What I was referring to was that if we rush to get the contacts support added in the next couple hours, we could miss something in Contacts that we'd want to change, and end up regretting not being able to change it in the future

I'd love to get your code in.. I'm super excited that you're contributing it, but I just don't want to rush it the night of the freeze.

Can we work to get this reviewed this week, committed in trunk and then give the Google Group for contacts a chance to test it out before the 1.7 freeze?

Cheers,
-Ryan


Darien Hager - 30/Jun/08 04:56 PM
Sure, I have no particular objection to delaying it until 1.7, I just misunderstood the scope of the freeze.

On a unrelated note, I've been toying with is a Gdata adapter for Zend_Auth, but I'm running into some ambiguities since usernames are not necessarily unique due to context (service used, real gmail vs hosted corporate, etc.)


Darien Hager - 07/Jul/08 05:40 PM
The Not-Yet-Ready-For-Real-Review proposal is now up in the wiki...

http://framework.zend.com/wiki/display/ZFPROP/Zend_Gdata_Contacts+-+Darien+Hager

I'll focus on adding more skeleton examples while waiting for the corporate gears to grind.


Ryan Boyd - 07/Jul/08 08:46 PM
Hi Darien,

Great - thanks for the proposal! We'll happily review it. As this is not a new component, but rather just some new classes for an existing component (Zend_Gdata), I don't believe it really needs a formalized proposal.

Good luck with the "corporate gears."

Cheers,
-Ryan


Curt Larson - 11/Jul/08 11:03 AM
Thanks for your great work on this Darien. I might need to get this implemented before Darien gets throught he legal gears, could anyone give me a hand on how to do this manually? I'd be fine if I could just extract the raw data from google, but not sure how to do it. Ideally actually I'd just like to get it in JSON.

Here is what I'm doing:
$contact = new Zend_Gdata($client);
$query = new Zend_Gdata_Query(
'http://www.google.com/m8/feeds/contacts/default/full');
$query->setMaxResults(2000);
$feed = $contact->getFeed($query);

foreach ($feed as $entry) {
print 'Title: ' . $entry->title->text;

I do get the names of the contacts out, but don't know how to get the other data I need (which is just phone number and email address).

Thanks for any help!

Curt


Ryan Boyd - 11/Jul/08 11:31 AM
@Curt

This should get you the JSON version of the feed you're looking for...

<?php

require_once 'Zend/Gdata/ClientLogin.php';
require_once 'Zend/Gdata.php';

$client = Zend_Gdata_ClientLogin::getHttpClient('email address', 'password', 'cp');
$gd = new Zend_Gdata($client);

$response = $gd->get('http://www.google.com/m8/feeds/contacts/default/full?max-results=2000&alt=json');
echo $response->getBody();


Darien Hager - 11/Jul/08 11:35 AM
Here's some code that ought to work:
foreach($feed as $entry){
	print("<h1>".$entry->title."</h1>");		
	$parts = $entry->getExtensionElements();
	foreach($parts as $p){		
		$element = $p->getDOM();				
		switch($element->tagName){
			case 'email':
				print("Email: ".$element->getAttribute('address')."<br/>");
				break;
			case 'phoneNumber':
				print("Phone: ".$element->nodeValue."<br/>");
				break;
			default:
				continue;
		}
	}	
}

Darien Hager - 11/Jul/08 11:39 AM
P.S.: If you want information about categories, e.g. "Work", "Personal", or phone-number subtypes such as "mobile" and "fax", I have a little rant about how that's painful:

http://groups.google.com/group/google-contacts-api/browse_thread/thread/d824900520a4d6f0#


Curt Larson - 11/Jul/08 01:03 PM
Thanks guys for the very fast response - worked out well.

Thanks,

Curt


Darien Hager - 11/Aug/08 10:20 AM
Pfhew. Waiting for Zend response to the corporate CLA.

Darien Hager - 13/Aug/08 10:16 AM
Still waiting... But what's the procedure here, just toss up a zip of sources and someone else commits it to the right place in SVN?

Trevor Johns - 13/Aug/08 08:48 PM
Hey Darien,
The preferred way is to upload a patch in unified diff format created by running 'svn diff'.

Once that's done, the community will have a chance to review the patch and provide feedback. Once everybody's happy with it, I can go ahead and check the code into SVN for you.

Thanks for all of your hard work on this.


Darien Hager - 14/Aug/08 10:42 AM
As diffed against the 1.5.3 release tag.

Only minor changes on existing code, otherwise new files.


Darien Hager - 14/Aug/08 10:45 AM
Okay, there it is.

Caveats: I have not recently re-tested it. Google may have changed their API. In fact, I'm pretty sure the category stuff ("Work","Personal") is broken, or at the least a bit iffy.

Google might have cleaned up that aspect of their API, but last I checked that particular categorization feature was iffy.


Darien Hager - 14/Aug/08 11:27 AM
Note to self: Proof-read more next time.

The following Google tickets/issues are probably germane:
http://code.google.com/p/gdata-issues/issues/detail?id=653
http://code.google.com/p/gdata-issues/issues/detail?id=639

It seems some of the docs may have been updated with more about possible 'rel' attribute values:
http://code.google.com/apis/gdata/elements.html

Turns out the patch I posted is already broken (broken assertion) when it encounters rel="http://schemas.google.com/g/2005#work_fax"


Darien Hager - 27/Aug/08 07:33 PM
Due to unexpected developments I will not be able to proactively develop this feature at this time, so I'm changing it to unassigned. I will however try to keep watching the issue and helping as time permits.

Trevor Johns - 27/Aug/08 09:49 PM
No worries Darren, I can help finish it up. Speaking of which, I'm hoping to finish going through the patch within the next week.

Trevor Johns - 27/Aug/08 09:50 PM
Err, Darien. Sorry about that.

Trevor Johns - 26/Feb/09 05:25 PM
Increasing priority to major.