[#ZF-3472] Zend_Controller_Request_Abstract::setParams is not unsetting pre-existing values - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.5.1, 1.5.2
Fix Version/s: 1.11.11
Component/s: Zend_Controller
Labels:
- zf-crteam-padraic
- zf-crteam-priority

Description

require_once 'Zend/Controller/Request/Simple.php';
$r = new Zend_Controller_Request_Simple();
$r->setParam('key', 'value');
$r->setParams(
    array(
        'key' => null
    )
);
var_dump($r->getParams());

The preceding code should output:

array(0) {
}

but is actually outputting:

array(1) {
  ["key"]=>
  string(5) "value"
}

getParams() should be returning an empty array because setParams is defining key to be null and should therefore be calling unset on that value.

If I modified the code to the following, then everything works as expected.

<?php
require_once 'Zend/Controller/Request/Simple.php';
$r = new Zend_Controller_Request_Simple();
$r->setParam('key', 'value');
$r->setParam('key', null);
var_dump($r->getParams())

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Stefano Tamagnini added a comment - 05/Mar/10 12:15 PM

REFERENCE ZF 1.10.1
try:

$request->setParam('variable',null);
unset($_GET['variable']);
unset($_POST['variable']);

correct unset variable into Zend_Controller_Request_Http, because into Zend_Controller_Request_Http on getParam(...)
it try to find variable name into $_GET & $_POST :

public function getParam($key, $default = null)
    {
        $keyName = (null !== ($alias = $this->getAlias($key))) ? $alias : $key;

        $paramSources = $this->getParamSources();
        if (isset($this->_params[$keyName])) {
            return $this->_params[$keyName];
        } elseif (in_array('_GET', $paramSources) && (isset($_GET[$keyName]))) {
            return $_GET[$keyName];
        } elseif (in_array('_POST', $paramSources) && (isset($_POST[$keyName]))) {
            return $_POST[$keyName];
        }

        return $default;
    }

Show

Stefano Tamagnini added a comment - 05/Mar/10 12:15 PM REFERENCE ZF 1.10.1 try:

$request->setParam('variable',null);
unset($_GET['variable']);
unset($_POST['variable']);

correct unset variable into Zend_Controller_Request_Http, because into Zend_Controller_Request_Http on getParam(...) it try to find variable name into $_GET & $_POST :

public function getParam($key, $default = null)
    {
        $keyName = (null !== ($alias = $this->getAlias($key))) ? $alias : $key;

        $paramSources = $this->getParamSources();
        if (isset($this->_params[$keyName])) {
            return $this->_params[$keyName];
        } elseif (in_array('_GET', $paramSources) && (isset($_GET[$keyName]))) {
            return $_GET[$keyName];
        } elseif (in_array('_POST', $paramSources) && (isset($_POST[$keyName]))) {
            return $_POST[$keyName];
        }

        return $default;
    }

Hide

Permalink

Ralph Schindler added a comment - 17/Feb/11 3:37 PM

Matthew, any notes on this?

Show

Ralph Schindler added a comment - 17/Feb/11 3:37 PM Matthew, any notes on this?

Hide

Permalink

Pádraic Brady added a comment - 13/Aug/11 9:49 PM

Fixed r24372. No apparent test breakages. Null check in method doesn't verify against original parameter so it missed the array addition issue.

Show

Pádraic Brady added a comment - 13/Aug/11 9:49 PM Fixed r24372. No apparent test breakages. Null check in method doesn't verify against original parameter so it missed the array addition issue.

People

Assignee:

Pádraic Brady

Reporter:

Cole Snodgrass

Vote (2)

Watch (2)

Dates

Created:

17/Jun/08 6:47 PM

Updated:

13/Aug/11 9:49 PM

Resolved:

13/Aug/11 9:49 PM