|
|
|
[
Permlink
| « Hide
]
Daniel Bezruchkin - 13/Oct/06 06:43 PM
Extracting this into your zend directory will get RDF feeds to work.
The attached zip doesn't work. It makes a major error (blank page). Will investigate on the error.
It's because of:
$success = @$doc->loadXML(Zend_Feed::utf8ToUnicodeEntities($string)); in Feed.php The utf8ToUnicodeEntities function doesn't exist (wrong code version?) In the previous version it was: I have the exact same issue. Any idea when this will be resolved? I've used PEAR's RSS class, no good. I've used Magpie/simplepie, no good. This one was able to parse all of the new feeds but cannot parse the 1.0 rdf feeds. So it's the best so far!
This bug depends on
RSS 1.0 lists items outside channel node and Zend_Feed actually can't handle this situation. Rather than fixing the behavior, I would suggest to add a new RDF class, as proposed in the description of this issue. The main difference between RSS 0.91 branch (created by Dave Winer) and RSS 1.0 branch (managed by RSS-DEV Working Group) is that the latter is RDF based while RDF architecture has been completely removed in RSS 0.91, RSS 0.92, RSS 2.0. Additionally, I would suggest to add a new class property to return feed type/version.
I forgot to say that my previous comment has been inspired by http://www.nabble.com/zend-feed-issue--tf4928553s16154.html#a14108105
The only difference between RSS 1.0 and other versions that is related to this issue is that item elements are not contained within the channel element. The attached file patch.diff modifies Zend_Feed_Rss to check for this and also patches the appropriate test in the test suite so that, without the patch to Zend_Feed_Rss, RSS 1.0 feed tests will fail.
Hi Matthew,
I gave a look at the patch you submitted a few days ago. The following line doesn't really makes sense to me.
_importRssValid method is an utility method and we cannot assume in advance the file he's going to fetch is not a valid empty feed. The other part of the patch, the code fragment that should introduce RSS 1.0 compatibility it's fine, but I think it's incomplete. Did you think about how an imported RSS 1.0 feed will be printed out? What do you propose to fix this consequential issue? For the sake of completeness, I'd like to share an additional though. Any news on this feature?
I would suggest to change status to unassigned if work is not in progress. I am resolving then reoping this bug, since its occupied over a year now.
Please raise your voice Matthew if this a no go by me any news on this bug?
i think its just including the patch? As far as I'm aware, no conflicting changes have been made to Zend_Feed_Rss since this patch was suggested, so the patch should work. Note that only the portion of the patch for library/Zend/Feed/Rss.php is really needed.
In terms of the portion that patches tests, it may be a better design decision to create an additional supporting method that first calls _importRssValid and then applies a non-empty check, and have all tests with non-empty test data files call that instead of _importRssValid, so that cases where data is expected to be empty can continue to function as normal. Thoughts anyone? Matthew, could you please evaluate the proposed solution and determine what we need to do to get this fixed? According to the votes, there seems to be a lot of interest in this issue.
I've considered Simone's point and have updated my patch accordingly. _importRssValid no longer checks the feed item count in this new patch. Instead, it modifies _importRssValid to return the $feed object it creates to be used by the calling method and modifies the two existing RSS 1.0 test methods to check their respective feed item counts.
I've applied my patch to Zend_Feed_Rss in a current SVN checkout to confirm that it still works. If I run the modified unit tests on the unpatched version of this class file, I get this output: $ phpunit Zend_Feed_ImportTest tests/Zend/Feed/ImportTest.php PHPUnit 3.3.8 by Sebastian Bergmann. ..............FF.......... Time: 3 seconds There were 2 failures: 1) testRss100Sample1(Zend_Feed_ImportTest) Failed asserting that <integer:2> matches expected value <integer:0>. 2) testRss100Sample2(Zend_Feed_ImportTest) Failed asserting that <integer:1> matches expected value <integer:0>. FAILURES! Tests: 26, Assertions: 30, Failures: 2. If I apply the patch and run the modified unit tests again, I get this output: $ phpunit Zend_Feed_ImportTest tests/Zend/Feed/ImportTest.php PHPUnit 3.3.8 by Sebastian Bergmann. .......................... Time: 2 seconds OK (26 tests, 30 assertions) Is this an acceptable solution? Resolved issue, i have verified and applied Matthews Testcases and Bugfixes. Thanks! Two very old bugs gone now
Sorry, not in 1.7.4. I think it may be released in next minor.
The problem is reproducable with some feeds like
http://ranking.goo.ne.jp/rss/keyword/keyrank_all1/index.rdf The source of that feed begins with Zend_Feed_Rss#__wakeup() checks if the feed is rdf or not with the following code Quick fix for the client user: To fix the problem, replace the following in Zend_Feed_Rss#__wakeup()
// Find the base channel element and create an alias to it. if ($this->_element->firstChild->nodeName == 'rdf:RDF') { $this->_element = $this->_element->firstChild; } else { with // Find the base channel element and create an alias to it. $rdf = $this->_element->getElementsByTagNameNS('http://www.w3.org/1999/02/22-rdf-syntax-ns#', 'RDF')->item(0); if ($rdf) { $this->_element = $rdf; } else { Was this added to 1.8.1? I don't see a Zend_Feed_Rdf class...
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||