Zend Framework

Zend_Soap_AutoDiscover is using hardcoded http schema

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6.0RC3, 1.6.0, 1.6.1, 1.6.2, 1.7 Preview Release
  • Fix Version/s: 1.7.0
  • Component/s: Zend_Soap_Server, Zend_Soap_Wsdl
  • Labels:
    None

Description

Zend_Soap_AutoDiscover is using Zend_Uri::factory('http://' ... to create a services uri - it should at least be able to correctly discover https.

Kind regards,
Thomas Gelf

Attachments

  1. Text File
    AutoDiscoverSetUri.php.patch
    07/Oct/08 12:48 AM
    7 kB
    Benjamin Eberlei
  2. Text File
    AutoDiscoverTestSetUri.php.patch
    07/Oct/08 12:50 AM
    0.8 kB
    Benjamin Eberlei
  3. Text File
    Zend_Soap_AutoDiscover.https.patch
    29/Aug/08 7:41 AM
    0.7 kB
    Thomas Gelf
  4. Text File
    Zend_Soap_AutoDiscover.targetNamespace.patch
    12/Sep/08 1:27 PM
    4 kB
    Marcus Welz
  5. Text File
    Zend_Soap_AutoDiscover.uri.patch
    29/Aug/08 10:19 AM
    1 kB
    Marcus Welz

Issue Links

This issue is duplicated by:
ZF-4172 Zend_Soap_Autodiscovery hardcoded URI Blocker Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas Gelf added a comment -

You can find a possible way to fix this issue in the attached patch file.

Cheers,
Thomas

Show
Thomas Gelf added a comment - You can find a possible way to fix this issue in the attached patch file. Cheers, Thomas
Hide
Permalink
Marcus Welz added a comment -

Would it make sense to allow for more flexibility with setting the Uri? For cases of mod_rewrite, in context of MVC, etc. Patch attached.

Thanks!

Show
Marcus Welz added a comment - Would it make sense to allow for more flexibility with setting the Uri? For cases of mod_rewrite, in context of MVC, etc. Patch attached. Thanks!
Hide
Permalink
Thomas Gelf added a comment -

Full ack, absolutely great!

Show
Thomas Gelf added a comment - Full ack, absolutely great!
Hide
Permalink
Apaella added a comment -

I ran in the same problem. Same solution

Show
Apaella added a comment - I ran in the same problem. Same solution
Hide
Permalink
Marcus Welz added a comment -

Zend_Soap_AutoDiscover.targetNamespace.patch allows for setting the soap endpoint url separately from the target namespace.

Show
Marcus Welz added a comment - Zend_Soap_AutoDiscover.targetNamespace.patch allows for setting the soap endpoint url separately from the target namespace.
Hide
Permalink
Thomas Gelf added a comment -

Like for Ing. Jitka Darbujanova in ZF-4172 this issue is a showstopper for me, Zend_Soap_AutoDiscover disallows HTTPS and setting uri / location / whatever on a personal choice is impossible. The patches attached to this bug report are easy to understand and shouldn't break anything - it would be great if someone could take care of this ticket. Issue is still there in 1.6.1.

Best regards,
Thomas Gelf

Show
Thomas Gelf added a comment - Like for Ing. Jitka Darbujanova in ZF-4172 this issue is a showstopper for me, Zend_Soap_AutoDiscover disallows HTTPS and setting uri / location / whatever on a personal choice is impossible. The patches attached to this bug report are easy to understand and shouldn't break anything - it would be great if someone could take care of this ticket. Issue is still there in 1.6.1. Best regards, Thomas Gelf
Hide
Permalink
Thomas Gelf added a comment -

Oops! I somehow managed it to toggle assignment, sorry.
I'll let it be reassigned automatically...

Show
Thomas Gelf added a comment - Oops! I somehow managed it to toggle assignment, sorry. I'll let it be reassigned automatically...
Hide
Permalink
Benjamin Eberlei added a comment -

Sorry, all three patches are bogus..

The first one is just a hack to solve the HTTPS problem, the second and third ones ignore the setFunction alltogether. None provides unittests and documentation changes.

Also the one with setUri (Zend_Soap_Autodiscover.uri.php) has the problem that when setClass is called BEFORE setUri, the uri setting is ignored. This is not desired behaviour since its common expectation that the setter functions of webservice objects (like SOAPServer) only begin to act on calling $server->handle();

I have attached a patch that allows changing the default wsdl location uri only by constructor, to handle the problem described in the above paragraph. I have added a unittest to check for the changed webservice url and a proposed change to the documentation.

To allow for a setUri function to be accessible for the public scope, underlying changes to the WSDL component have to be done. Therefore my setUri function is just private for the time being, hoping that the WSDL component will be refactored someday to be more flexible.

Show
Benjamin Eberlei added a comment - Sorry, all three patches are bogus.. The first one is just a hack to solve the HTTPS problem, the second and third ones ignore the setFunction alltogether. None provides unittests and documentation changes. Also the one with setUri (Zend_Soap_Autodiscover.uri.php) has the problem that when setClass is called BEFORE setUri, the uri setting is ignored. This is not desired behaviour since its common expectation that the setter functions of webservice objects (like SOAPServer) only begin to act on calling $server->handle(); I have attached a patch that allows changing the default wsdl location uri only by constructor, to handle the problem described in the above paragraph. I have added a unittest to check for the changed webservice url and a proposed change to the documentation. To allow for a setUri function to be accessible for the public scope, underlying changes to the WSDL component have to be done. Therefore my setUri function is just private for the time being, hoping that the WSDL component will be refactored someday to be more flexible.
Hide
Permalink
Benjamin Eberlei added a comment -
  • add private setUri function (due to problems in communication with WSDL component)
  • add new variable in constructor taking Zend_Uri|string and saving to $this->_uri
  • change setClass to test for $this->_uri
  • change setFunction to test for $this->_uri
Show
Benjamin Eberlei added a comment -
  • add private setUri function (due to problems in communication with WSDL component)
  • add new variable in constructor taking Zend_Uri|string and saving to $this->_uri
  • change setClass to test for $this->_uri
  • change setFunction to test for $this->_uri
Hide
Permalink
Benjamin Eberlei added a comment -
  • Add Test-Case for AutoDiscover setting Uri via constructor

The corresponding file to this comments are AutoDiscoverTestSetUri.php.patch and AutoDiscoverSetUri.php.patch

Show
Benjamin Eberlei added a comment -
  • Add Test-Case for AutoDiscover setting Uri via constructor
The corresponding file to this comments are AutoDiscoverTestSetUri.php.patch and AutoDiscoverSetUri.php.patch
Hide
Permalink
Benjamin Eberlei added a comment -

Fixed in Trunk via second constructor parameter $uri or function setUri($uri).

Show
Benjamin Eberlei added a comment - Fixed in Trunk via second constructor parameter $uri or function setUri($uri).
Hide
Permalink
Thomas Gelf added a comment -

Thank you for fixing this, setUri() is a great addition. However my initial bug report regarded hardcoded http schema and autodetection. My proposed patch is not a hack, schema detection is done the same way in other parts of the Zend Framework (Controller, OpenID...). And it requires no new documentation as it fixes existing behaviour conforming to what a developer would expect from an "autodiscover" component.

Not using HTTPS is not an option for most webservices today, and if there is an autodetection component it should also detect wheter I'm running HTTPS or not. I do NOT want to have to either do schema detection in my controllers and I do NOT want to hardcode / configure URIs in my application. Schema detection should work out of the box - and adding port detection for non-standard ports would also be a nice-to-have feature.

Adding schema detection from my very first patch to your setUri() function would solve this, adding port detection (like Zend_OpenId::selfUrl()) would be a nice addition.

Best regards,
Thomas Gelf

NB: Sorry for impudently reopening this issue

Show
Thomas Gelf added a comment - Thank you for fixing this, setUri() is a great addition. However my initial bug report regarded hardcoded http schema and autodetection. My proposed patch is not a hack, schema detection is done the same way in other parts of the Zend Framework (Controller, OpenID...). And it requires no new documentation as it fixes existing behaviour conforming to what a developer would expect from an "autodiscover" component. Not using HTTPS is not an option for most webservices today, and if there is an autodetection component it should also detect wheter I'm running HTTPS or not. I do NOT want to have to either do schema detection in my controllers and I do NOT want to hardcode / configure URIs in my application. Schema detection should work out of the box - and adding port detection for non-standard ports would also be a nice-to-have feature. Adding schema detection from my very first patch to your setUri() function would solve this, adding port detection (like Zend_OpenId::selfUrl()) would be a nice addition. Best regards, Thomas Gelf NB: Sorry for impudently reopening this issue
Hide
Permalink
Benjamin Eberlei added a comment -

i am sorry, misunderstood the issue (overstepped it). I'll fix the HTTPS issue right away.

Show
Benjamin Eberlei added a comment - i am sorry, misunderstood the issue (overstepped it). I'll fix the HTTPS issue right away.
Hide
Permalink
Benjamin Eberlei added a comment -

Fixed detection of HTTPS schema in trunk

Show
Benjamin Eberlei added a comment - Fixed detection of HTTPS schema in trunk
Hide
Permalink
Wil Sinclair added a comment -

Changing issues in preparation for the 1.7.0 release.

Show
Wil Sinclair added a comment - Changing issues in preparation for the 1.7.0 release.

People

Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.