Zend Framework

All or most Zend_Soap_* files are containing a mix of dos and unix newlines

Details

  • Type: Coding Standards Violation Coding Standards Violation
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.6.0RC3, 1.6.1
  • Fix Version/s: 1.6.2
  • Component/s: Zend_Soap_Wsdl
  • Labels:
    None
  • Fix Version Priority:
    Nice to Have

Description

:-p

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Satoru Yoshida added a comment -

Solved in SVN r11270 Zend/Soap/Client/Local.php has not only LF and also CR as newline mark.

I save Zend/Soap/Client/Local.php to contain only LF.

Show
Satoru Yoshida added a comment - Solved in SVN r11270 Zend/Soap/Client/Local.php has not only LF and also CR as newline mark. I save Zend/Soap/Client/Local.php to contain only LF.
Hide
Permalink
Thomas Gelf added a comment -

Issue not fixed, the following files still partly contain wrong newlines (a mix of dos/unix in each of them):

Soap/AutoDiscover.php
Soap/Client.php
Soap/Wsdl.php
Soap/Client/Local.php
Soap/Wsdl/CodeGenerator.php
Soap/Wsdl/Parser.php
Soap/Wsdl/Parser/Result.php

Show
Thomas Gelf added a comment - Issue not fixed, the following files still partly contain wrong newlines (a mix of dos/unix in each of them): Soap/AutoDiscover.php Soap/Client.php Soap/Wsdl.php Soap/Client/Local.php Soap/Wsdl/CodeGenerator.php Soap/Wsdl/Parser.php Soap/Wsdl/Parser/Result.php
Hide
Permalink
Satoru Yoshida added a comment -

Do You have CLA? I think You can correct them because You may know more information than me.

Show
Satoru Yoshida added a comment - Do You have CLA? I think You can correct them because You may know more information than me.
Hide
Permalink
Thomas Gelf added a comment -

Full patch for all wrong lines attached.

I signed and mailed CLA at the beginning of this year - I hope they got it, as I never got a response
Could you submit the patch for me? I have no SVN access - patch is against revision 11416, so it should be fine.

Best regards,
Thomas

Show
Thomas Gelf added a comment - Full patch for all wrong lines attached. I signed and mailed CLA at the beginning of this year - I hope they got it, as I never got a response Could you submit the patch for me? I have no SVN access - patch is against revision 11416, so it should be fine. Best regards, Thomas
Hide
Permalink
Satoru Yoshida added a comment -

Solved in SVN r11560.

I change CRLF to LF in these files.

Show
Satoru Yoshida added a comment - Solved in SVN r11560. I change CRLF to LF in these files.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
15m
Original Estimate - 15 minutes
Remaining:
15m
Remaining Estimate - 15 minutes
Logged:
Not Specified
Time Spent - Not Specified
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.