ZF-4118: All or most Zend_Soap_* files are containing a mix of dos and unix newlines

Issue Type:
Coding Standards Violation
Created:
2008-08-29T07:45:40.000+0000
Last Updated:
2012-03-21T11:15:21.000+0000
Status:
Resolved
Fix version(s):
  • 1.6.2 (13/Oct/08)
Reporter:
Thomas Gelf (tgelf)
Assignee:
Satoru Yoshida (satoruyoshida)
Tags:
  • Zend_Soap_Wsdl
Related issues:
Attachments:

Description

:-p

Comments

Posted by old of Satoru Yoshida (yoshida@zend.co.jp) on 2008-09-06T08:44:19.000+0000

Solved in SVN r11270 Zend/Soap/Client/Local.php has not only LF and also CR as newline mark.

I save Zend/Soap/Client/Local.php to contain only LF.

Posted by Thomas Gelf (tgelf) on 2008-09-16T06:52:40.000+0000

Issue not fixed, the following files still partly contain wrong newlines (a mix of dos/unix in each of them):

Soap/AutoDiscover.php Soap/Client.php Soap/Wsdl.php Soap/Client/Local.php Soap/Wsdl/CodeGenerator.php Soap/Wsdl/Parser.php Soap/Wsdl/Parser/Result.php

Posted by old of Satoru Yoshida (yoshida@zend.co.jp) on 2008-09-16T07:40:27.000+0000

Do You have CLA? I think You can correct them because You may know more information than me.

Posted by Thomas Gelf (tgelf) on 2008-09-16T08:37:37.000+0000

Full patch for all wrong lines attached.

I signed and mailed CLA at the beginning of this year - I hope they got it, as I never got a response :-( Could you submit the patch for me? I have no SVN access - patch is against revision 11416, so it should be fine.

Best regards, Thomas

Posted by old of Satoru Yoshida (yoshida@zend.co.jp) on 2008-10-01T03:21:47.000+0000

Solved in SVN r11560.

I change CRLF to LF in these files.