Zend Framework

Zend_Db_Table_Row_Abstract does not properly rely on autoloading

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6.0
  • Fix Version/s: 1.8.2
  • Component/s: Zend_Db_Table
  • Labels:
    None

Description

Zend_Db_Table_Row_Abstract->findDependentRowset() and Zend_Db_Table_Row_Abstract->findParentRow() rely on Zend_loader::loadClass() for loading dependent and parent tables. This makes it impossible to use autoloading to find these classes and forces the developer to add all paths that may contain DB Table class to be added to the include_path.

In my application I have a custom loader which I registered with Zend_Loader::registerAutoload('My_Model_Loader'). However this loader never gets fired when working with dependent and parent tables because autoloading is not used within Zend_Db_Table_Row_Abstract.

Autoloading should be used before directly trying to load a class. With the proposed MVC filder structure there would be a model folders for each application module. Adding each model folder as an include path is less than ideal. Following a pattern similar to controller actions, it would be reasonable that someone would want to load a model from a specific module.

I'm able to get my application to work just fine by commenting out the try...catch that tries to load the class.

Attachments

  1. File
    Db_Table.diff
    07/Feb/09 9:40 AM
    7 kB
    Keith Pope
  2. File
    zf-4167.diff
    05/Mar/09 5:15 AM
    15 kB
    Keith Pope

Issue Links

This issue is dependecy of:
ZF-6611 Zend DbTable Row Class name->path problem Major Resolved
This issue duplicates:
ZF-3991 Add possibility to change loader class Major Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Keith Pope added a comment -

Linking these issue as they report the same problem

Show
Keith Pope added a comment - Linking these issue as they report the same problem
Hide
Permalink
Keith Pope added a comment -

Hi,

I would really like to see this included, also I believe this could become a blocker to Matthews Resource Autoloader proposal as this uses the autoloader.

Thx

Keith

Show
Keith Pope added a comment - Hi, I would really like to see this included, also I believe this could become a blocker to Matthews Resource Autoloader proposal as this uses the autoloader. Thx Keith
Hide
Permalink
Keith Pope added a comment - - edited

Attaching a patch for this issue, this is just a proof of concept for now and therefore no unit tests etc. This may be a good temporary fix until all the class loading problems have been sorted out.

Patch Purpose

Remove Zend_Loader dependency

Patch Details

  • Added new protected static property $_loader
  • Added new public static method setLoader()
  • Added new public static method loadClass()
  • Added new public static method getLoader()
  • Added new protected static method _setupLoader()

Patched From std trunk

The idea is that it works in a similar way to the setDefaultAdpater, the loader is either null (use autoloader) or a valid callback array. All the Zend_Db_Table classes then use Zend_Db_Table_Abstract::loadClass() to load their classes.

Show
Keith Pope added a comment - - edited Attaching a patch for this issue, this is just a proof of concept for now and therefore no unit tests etc. This may be a good temporary fix until all the class loading problems have been sorted out. Patch Purpose Remove Zend_Loader dependency Patch Details
  • Added new protected static property $_loader
  • Added new public static method setLoader()
  • Added new public static method loadClass()
  • Added new public static method getLoader()
  • Added new protected static method _setupLoader()
Patched From std trunk The idea is that it works in a similar way to the setDefaultAdpater, the loader is either null (use autoloader) or a valid callback array. All the Zend_Db_Table classes then use Zend_Db_Table_Abstract::loadClass() to load their classes.
Hide
Permalink
Keith Pope added a comment -

I am currently creating a new patch which is simpler after talking to Matthew about it.

Show
Keith Pope added a comment - I am currently creating a new patch which is simpler after talking to Matthew about it.
Hide
Permalink
Keith Pope added a comment -

Right here is my second attempt at patching this issue

I have simplified by just wrapping the Zend_Loader class in class_exists that use the autoloader.

Patch is from the 1.7.6 release and includes:

Patched Db Table files
Unit tests
Documentation

Hopefully I have got it right, see what you think.

Show
Keith Pope added a comment - Right here is my second attempt at patching this issue I have simplified by just wrapping the Zend_Loader class in class_exists that use the autoloader. Patch is from the 1.7.6 release and includes: Patched Db Table files Unit tests Documentation Hopefully I have got it right, see what you think.
Hide
Permalink
Jamal Fanaian added a comment -

This issue affects the use of the Zend_Application_Module_Autoloader in ZF 1.8.0.

Show
Jamal Fanaian added a comment - This issue affects the use of the Zend_Application_Module_Autoloader in ZF 1.8.0.
Hide
Permalink
Keith Pope added a comment -

The easiest way to fix this is to change the following in Loader.php

if (class_exists($class, false) || interface_exists($class, false)) {

to

if (class_exists($class) || interface_exists($class)) {

any ideas why it does not check the autoloader by default?

Show
Keith Pope added a comment - The easiest way to fix this is to change the following in Loader.php if (class_exists($class, false) || interface_exists($class, false)) { to if (class_exists($class) || interface_exists($class)) { any ideas why it does not check the autoloader by default?
Hide
Permalink
Matthew Weier O'Phinney added a comment -

Resolved in trunk and 1.8 release branch

Show
Matthew Weier O'Phinney added a comment - Resolved in trunk and 1.8 release branch

People

Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Zend Framework. Try JIRA - bug tracking software for your team.