[#ZF-4576] Zend_Session_Namespace::getIterator() returns ArrayObject instead of Iterator

Zend Framework

Created: 12/Oct/08 12:32 PM Updated: 15/Oct/08 02:25 PM

Component/s:

Zend_Session

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

Tags:
Participants:	julien PAULI, Ralph Schindler and Ryan Korczykowski

Description

« Hide

IteratorAggregate::getItterator should return instanceof Iterator: http://www.php.net/~helly/php/ext/spl/interfaceIteratorAggregate.html

Namespace returns ArrayObject which does not implement Iterator: http://www.php.net/~helly/php/ext/spl/classArrayObject.html

This is moot when using the namespace in a foreach since the foreach calls getItterator on the namespace, and again on the ArrayObject (Im think ).

Test:

Zend_Session::start();
$ns = new Zend_Session_Namespace('test-namespace');
assert($ns->getIterator() instanceof Iterator);

Possible Fix:

Zend_Session_Namespace 182:         return new ArrayIterator(parent::_namespaceGetAll($this->_namespace));

Version:
I don't know what version the trunk refers to, here is the @version annotation
$Id: Namespace.php 11003 2008-08-24 14:43:15Z matthew $

All

Comments

Work Log

Change History

FishEye

Crucible

Sort Order:

[ Permlink | « Hide ]

You are rigth, it's called twice.

However, the patch could break backward compatibility as some users might use specific ArrayObject methods that would raise a fatal error.