[#ZF-4586] Zend_Form_Element_File does not work without filters - Zend Framework Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.7 Preview Release
Fix Version/s: 1.7.0
Component/s: Zend_Form
Labels:
None

Description

Zend_Form_Element_File does not work without filters.

It dies on 'Fatal error: Unsupported operand types in Zend\File\Transfer\Adapter\Abstract.php on line 796', when no filter is set. It is some kind of array merging problem.

When I add a filter, ->addFilter(new Zend_Filter_File_Rename('XXX', 'XXX')), it works OK

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Thomas Weidner added a comment - 13/Oct/08 11:01 AM

Is works without filters.
Most of the unittests are done without attached filters.

Please give reproducable code so we can investigate the problem in the file element.

Show

Thomas Weidner added a comment - 13/Oct/08 11:01 AM Is works without filters. Most of the unittests are done without attached filters. Please give reproducable code so we can investigate the problem in the file element.

Hide

Permalink

Martin Hujer added a comment - 13/Oct/08 11:09 AM

Problem is with $form->getValues()

$form = new Zend_Form();
        $form->setName('upload_form');
        
        $form->setMethod(Zend_Form::METHOD_POST);
        $form->setEnctype('multipart/form-data');
        
        $element = new Zend_Form_Element_File('upload_file');
        $element->setLabel('Upload:')
            ->setDestination('C:\Temp')
            //->addFilter(new Zend_Filter_File_Rename('XXX', 'XXX')) //uncomment to get example working
            ;
        $form->addElement($element);
        
        $form->addElement(new Zend_Form_Element_Submit(array(
            'name' => 'Submit',
        )));
        
        $this->view->form = $form;
        
         if ($this->getRequest()->isPost()) {
            if (!$form->isValid($_POST)) {
                echo "Error";
            } else {
                Zend_Debug::dump($form->getValues()); //Problem is HERE!
            }
        }

Show

Martin Hujer added a comment - 13/Oct/08 11:09 AM Problem is with $form->getValues()

$form = new Zend_Form();
        $form->setName('upload_form');
        
        $form->setMethod(Zend_Form::METHOD_POST);
        $form->setEnctype('multipart/form-data');
        
        $element = new Zend_Form_Element_File('upload_file');
        $element->setLabel('Upload:')
            ->setDestination('C:\Temp')
            //->addFilter(new Zend_Filter_File_Rename('XXX', 'XXX')) //uncomment to get example working
            ;
        $form->addElement($element);
        
        $form->addElement(new Zend_Form_Element_Submit(array(
            'name' => 'Submit',
        )));
        
        $this->view->form = $form;
        
         if ($this->getRequest()->isPost()) {
            if (!$form->isValid($_POST)) {
                echo "Error";
            } else {
                Zend_Debug::dump($form->getValues()); //Problem is HERE!
            }
        }

Hide

Permalink

Thomas Weidner added a comment - 13/Oct/08 11:54 AM

Probably fixed with r11936.

Show

Thomas Weidner added a comment - 13/Oct/08 11:54 AM Probably fixed with r11936.

Hide

Permalink

Martin Hujer added a comment - 13/Oct/08 11:59 AM

It shows "Warning: Invalid argument supplied for foreach() in Zend\Form\Element.php on line 524" now

line 524:
foreach ($this->getFilters() as $filter) {
            $value = $filter->filter($value);
        }

You should probably return some array.

Show

Martin Hujer added a comment - 13/Oct/08 11:59 AM It shows "Warning: Invalid argument supplied for foreach() in Zend\Form\Element.php on line 524" now

line 524:
foreach ($this->getFilters() as $filter) {
            $value = $filter->filter($value);
        }

You should probably return some array.

Hide

Permalink

Thomas Weidner added a comment - 13/Oct/08 12:00 PM

What should getValues() be for a function ?
File Elements do not have a value !!!

Calling this method on file elements will return unexpected values.

Show

Thomas Weidner added a comment - 13/Oct/08 12:00 PM What should getValues() be for a function ? File Elements do not have a value !!! Calling this method on file elements will return unexpected values.

Hide

Permalink

Martin Hujer added a comment - 13/Oct/08 12:09 PM

patch:

Index: Zend/Form/Element/File.php
===================================================================
--- Zend/Form/Element/File.php	(revision 11936)
+++ Zend/Form/Element/File.php	(working copy)
@@ -354,7 +354,10 @@
     public function getFilters()
     {
         $adapter = $this->getTransferAdapter();
-        return $adapter->getFilters($this->getName());
+        $filters = $adapter->getFilters($this->getName());
+		if (!is_array($filters)) {
+			return array();
+		}
     }
 
     /**

Show

Martin Hujer added a comment - 13/Oct/08 12:09 PM patch:

Index: Zend/Form/Element/File.php
===================================================================
--- Zend/Form/Element/File.php	(revision 11936)
+++ Zend/Form/Element/File.php	(working copy)
@@ -354,7 +354,10 @@
     public function getFilters()
     {
         $adapter = $this->getTransferAdapter();
-        return $adapter->getFilters($this->getName());
+        $filters = $adapter->getFilters($this->getName());
+		if (!is_array($filters)) {
+			return array();
+		}
     }
 
     /**

Hide

Permalink

Martin Hujer added a comment - 13/Oct/08 12:19 PM

Sorry, the right patch:

Index: Zend/Form/Element/File.php
===================================================================
--- Zend/Form/Element/File.php	(revision 11937)
+++ Zend/Form/Element/File.php	(working copy)
@@ -354,7 +354,11 @@
     public function getFilters()
     {
         $adapter = $this->getTransferAdapter();
-        return $adapter->getFilters($this->getName());
+        $filters = $adapter->getFilters($this->getName());
+        if (!is_array($filters)) {
+            $filters = array();
+        }
+        return $filters;
     }
 
     /**

Show

Martin Hujer added a comment - 13/Oct/08 12:19 PM Sorry, the right patch:

Index: Zend/Form/Element/File.php
===================================================================
--- Zend/Form/Element/File.php	(revision 11937)
+++ Zend/Form/Element/File.php	(working copy)
@@ -354,7 +354,11 @@
     public function getFilters()
     {
         $adapter = $this->getTransferAdapter();
-        return $adapter->getFilters($this->getName());
+        $filters = $adapter->getFilters($this->getName());
+        if (!is_array($filters)) {
+            $filters = array();
+        }
+        return $filters;
     }
 
     /**

Hide

Permalink

Thomas Weidner added a comment - 13/Oct/08 12:56 PM

Should now work with r11939

Show

Thomas Weidner added a comment - 13/Oct/08 12:56 PM Should now work with r11939

Hide

Permalink

Goran Juric added a comment - 12/Nov/08 5:39 PM

I can confirm that this works for me now! Finally

Thanks...

Show

Goran Juric added a comment - 12/Nov/08 5:39 PM I can confirm that this works for me now! Finally

Thanks...

Hide

Permalink

Wil Sinclair added a comment - 13/Nov/08 2:10 PM

Changing issues in preparation for the 1.7.0 release.

Show

Wil Sinclair added a comment - 13/Nov/08 2:10 PM Changing issues in preparation for the 1.7.0 release.

People

Assignee:

Thomas Weidner

Reporter:

Martin Hujer

Vote (0)

Watch (1)

Dates

Created:

13/Oct/08 9:07 AM

Updated:

13/Nov/08 2:10 PM

Resolved:

13/Oct/08 1:57 PM

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: