[#ZF-4743] Zend_Session is too aggressive about catching errors during session_start

Zend Framework

Zend_Session is too aggressive about catching errors during session_start

Created: 29/Oct/08 02:05 PM Updated: 19/May/09 11:12 AM

Component/s:

Zend_Session

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

Tags:
Participants:	Ralph Schindler, Till Klampaeckel and Todd Lipcon

Description

« Hide

Zend_Session installs an error handler to catch any errors triggered by session_start, and then rethrows them as an exception if it caught any. However, it catches all errors (mask set to E_ALL)

This causes problems when session_start writes NOTICE level errors which probably do not signify a session_start problem.

I'd propose changing the set_error_handler call:

set_error_handler(array('Zend_Session_Exception', 'handleSessionStartError'), E_ALL);
to
set_error_handler(array('Zend_Session_Exception', 'handleSessionStartError'), E_ALL & ~E_NOTICE);

Not sure what version this is, but the RCS tags at the top say:

@version $Id: Session.php 5500 2007-06-29 14:39:50Z darby $
@since Preview Release 0.2

All

Comments

Work Log

Change History

FishEye

Crucible

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Till Klampaeckel - 02/May/09 11:12 AM

This is a show stopper.

[ Permlink | « Hide ]

Ralph Schindler - 19/May/09 11:12 AM

Resolved as part of r15640 for ~~ZF-3020~~, see the option throw_startup_exceptions- the ability to pass in a integer (error level)