ZF-4934: testAdvancedLogging(Zend_Log_Writer_FirebugTest) unit tests error

Issue Type:
Unit Tests: Problem
Created:
2008-11-12T10:59:10.000+0000
Last Updated:
2009-01-13T18:01:40.000+0000
Status:
Resolved
Fix version(s):
  • 1.7.3 (19/Jan/09)
Reporter:
Alexander Veremyev (alexander)
Assignee:
Christoph Dorn (cadorn)
Tags:
  • Zend_Log
Related issues:
Attachments:

Description

{panel} 6) testAdvancedLogging(Zend_Log_Writer_FirebugTest) [json] (json_encode_r) type is unsupported, encoded as null. /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Json.php:100 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Json.php:100 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Wildfire/Protocol/JsonStream.php:150 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Wildfire/Protocol/JsonStream.php:97 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Wildfire/Plugin/FirePhp.php:448 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Wildfire/Plugin/FirePhp.php:401 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Log/Writer/Firebug.php:185 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Log/Writer/Abstract.php:80 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Log.php:153 /home/cawa/ZendFramework/svn/framework/trunk/library/Zend/Log.php:106 {panel}

Comments

Posted by Wil Sinclair (wil) on 2008-11-12T11:09:30.000+0000

These tests are taking a really long time in multiple environments, Christoph. Like >15min apeice. :O

Posted by Christoph Dorn (cadorn) on 2008-11-12T12:46:05.000+0000

I am not in a position to troubleshoot this until mid December. Sorry.

Posted by Christoph Dorn (cadorn) on 2008-11-12T13:04:10.000+0000

I believe the problem has to do with the is_resource() call I recently committed.

Posted by Wil Sinclair (wil) on 2008-11-12T13:17:57.000+0000

OK, no worries. I'm taking a look at it now, and I'll start by checking out is_resource().

Posted by Christoph Dorn (cadorn) on 2008-11-12T13:25:21.000+0000

Maybe we can cast the object to string and check for the "Resource #" string as the last IF check.

Posted by Alexander Veremyev (alexander) on 2008-11-13T03:15:10.000+0000

  1. Using '===' is enough to perform check if it's the same object really quickly. It actually compares only object ID's

  2. The problem is actualy in a really HUGE data structure passed to the logger.

While tracing it includes Upper level of PHPUnit objects + all ZF test case objects including their properties (additional objects using during testing)! It's large enough structure even Zend_Log_Writer_FirebugTest test case is started separately (takes ~25sec), but it becomes too large if whole ZF tests suite is started.

I'm going to mark testAdvancedLogging(Zend_Log_Writer_FirebugTest) as skipped since it passes without problems in a separate mode.

Posted by Alexander Veremyev (alexander) on 2008-11-13T03:25:11.000+0000

See r12606 and r12607.

Posted by Wil Sinclair (wil) on 2008-12-18T12:02:39.000+0000

Christoph, do you have any time to look at this now?

Posted by Christoph Dorn (cadorn) on 2008-12-18T14:23:40.000+0000

I'll get this fixed soon.

Posted by Christoph Dorn (cadorn) on 2009-01-13T18:01:40.000+0000

Should be fixed now. I am limiting the stack trace with:


Zend_Wildfire_Plugin_FirePhp::getInstance()->setOption('maxTraceDepth',0);